search

NOAA-EMC / fv3atm

Other
33 stars 157 forks source link

[production/RRFS.v1] saSAS sigmab initialization changes to reduce large initial reflectivity in RRFS and inline post bug fix for RUC LSM #869

Open JiliDong-NOAA opened 2 months ago

JiliDong-NOAA commented 2 months ago

Description

  1. This PR follows Jongil's suggestion and aims to reduce the large convective reflectivity caused by saSAS adjustment in the first timestep during a warm start. The issue is likely related to the inconsistency when DA updates the moisture at t but not the moisture from the previous timestep (t-36s). The moisture from the previous timestep is needed for initializing sigmab (updraft area fraction) when calculating qadv (q advection or tendency term).

The PR forces qadv to zero in the first timestep when a namelist parameter sigmab_coldstart is set to .true. It also reduces the lower limit of sigmab from 0.01 to 0.0 in the first timestep.

dependent on ccpp-physics PR:

https://github.com/ufs-community/ccpp-physics/pull/225

  1. Two bug fixes for LSM soil output with inline post are added in this PR: 2.1 https://github.com/NOAA-EMC/fv3atm/pull/877 2.2 @ericaligo-NOAA identified and fixed another bug with inline post when "lsoil" is different from "lsoil_lsm" which can happen when cold starting from Noah LSM input but running forecast with RUC LSM. In the above example, lsoil=4 and lsoil_lsm=9. There is no soil variables from inline post. The fix will set the correct "nsoil" based on lsoil_lsm and recover the LSM soil output.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository. (Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first? If so add the "waiting for other repos" label and list the upstream PRs

Requirements before merging

MatthewPyle-NOAA commented 1 month ago

@JiliDong-NOAA Is there a PR at the UFS level associated with this change?

JiliDong-NOAA commented 1 month ago

@JiliDong-NOAA Is there a PR at the UFS level associated with this change?

@MatthewPyle-NOAA not yet. I will do it later today. I am also considering to combine the inline post bug fix for RUC LSM here (https://github.com/NOAA-EMC/fv3atm/pull/877). That won't change any results when using offline post but will be helpful for developers using inline post for RRFS. Please let me know if there are any concerns.

JiliDong-NOAA commented 1 month ago

PR to ufs-weather-model is created:

https://github.com/ufs-community/ufs-weather-model/pull/2488

JiliDong-NOAA commented 2 weeks ago

@ericaligo-NOAA the nsoil bug fix is added. Please let me know if it looks ok.