NOAA-EMC / fv3atm

Other
33 stars 157 forks source link

Third reconciliation PR from production/RRFS.v1 #882

Closed grantfirl closed 6 days ago

grantfirl commented 1 month ago

Description

This is @AndersJensen-NOAA work. This is the same as https://github.com/NOAA-EMC/fv3atm/pull/790 except it targets the develop branch.

This PR points to changes to Thompson-Eidhammer microphysics ->

This PR is the first of many that will modernized, modularize, and streamline Thompson-Eidhammer microphysics.

This PR includes:

The addition of parameterized kind: REAL -> real(kind_phys) Consistent indentation Removal of GOTO statements
Adding metadata for physical constants needed by Thompson MP

Issue(s) addressed

None

Testing

To be tested on Hera using rt.conf

Dependencies

https://github.com/ufs-community/ccpp-physics/pull/229

Requirements before merging