This work corresponds to https://github.com/NOAA-EMC/fv3atm/pull/802 merged into production/RRFS.v1, except this is targeted at the develop branch. This was @haiqinli 's work.
-- Update the MYNN PBL, Smoke and subgrid cloud fraction for the RRFS.v1 code freeze.
Is a change of answers expected from this PR? Yes.
Issue(s) addressed
Non
Testing
Original testing for production/RRFS.v1 merge:
How were these changes tested? The changes were tested with retro runs and regression test.
What compilers / HPCs was it tested with? Intel compiler on Hera and Jet.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
Yes, because the physics changed.
Please commit the regression test log files in your ufs-weather-model branch
Yes, the regression test log file was committed.
New testing for develop branch merge:
Ran full rt.conf on Hera. The test_changes.list and RT log were pushed into the UFSWM PR.
Description
This work corresponds to https://github.com/NOAA-EMC/fv3atm/pull/802 merged into production/RRFS.v1, except this is targeted at the develop branch. This was @haiqinli 's work.
-- Update the MYNN PBL, Smoke and subgrid cloud fraction for the RRFS.v1 code freeze.
What bug does it fix, or what feature does it add? -- Merge the bugfix in the HAILCAST diagnostic code (unit issue) (https://github.com/NOAA-EMC/fv3atm/issues/320) -- Merge (https://github.com/NOAA-EMC/fv3atm/pull/801)
Is a change of answers expected from this PR? Yes.
Issue(s) addressed
Non
Testing
Original testing for production/RRFS.v1 merge:
How were these changes tested? The changes were tested with retro runs and regression test.
What compilers / HPCs was it tested with? Intel compiler on Hera and Jet.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below. Yes, because the physics changed. Please commit the regression test log files in your ufs-weather-model branch Yes, the regression test log file was committed.
New testing for develop branch merge: Ran full rt.conf on Hera. The test_changes.list and RT log were pushed into the UFSWM PR.
Dependencies
https://github.com/ufs-community/ccpp-physics/pull/230
Requirements before merging