search

NOAA-EMC / gfs-utils

Utility programs for global-workflow
0 stars 15 forks source link

Update gfs_bufr using the lastest version with bugzilla fix #19

Closed BoCui-NOAA closed 1 year ago

BoCui-NOAA commented 1 year ago

Update gfs_bufr.fd using the latest version of gfs-v16. fix global-workflow issue https://github.com/NOAA-EMC/global-workflow/issues/1245

KateFriedman-NOAA commented 1 year ago

@BoCui-NOAA Please open an issue in gfs-utils to link this PR to. Within the issue's main comment please include details of what is getting updated and why. Thanks!

BoCui-NOAA commented 1 year ago

@BoCui-NOAA Please open an issue in gfs-utils to link this PR to. Within the issue's main comment please include details of what is getting updated and why. Thanks!

@KateFriedman-NOAA I opened an issue in gfs-utils, will clean out the extra white space in the code.

KateFriedman-NOAA commented 1 year ago

@BoCui-NOAA I ran the gfspostsnd job within the global-workflow twice...1) first with the existing gfs_utils repo execs (e.g. existing gfs_bufr) as they are in our develop branch today and then 2) again using your develop branch version from this PR. The same gfs output was used for both job runs. Please see the following output on Orion if you'd like to compare (let me know if I should transfer this output and logs to Hera):

Run 1:

Log: /work/noaa/stmp/kfriedma/comrot/devtest/logs/2022010200/gfspostsnd.log.0
/work/noaa/stmp/kfriedma/comrot/devtest/gfs.20220102/00/products/atmos/bufr_0/
/work/noaa/stmp/kfriedma/comrot/devtest/gfs.20220102/00/products/atmos/gempak_0/

Run 2:

Log: /work/noaa/stmp/kfriedma/comrot/devtest/logs/2022010200/gfspostsnd.log
/work/noaa/stmp/kfriedma/comrot/devtest/gfs.20220102/00/products/atmos/bufr/
/work/noaa/stmp/kfriedma/comrot/devtest/gfs.20220102/00/products/atmos/gempak/
BoCui-NOAA commented 1 year ago

@KateFriedman-NOAA I compared the output files on Orion. The records are identical from the two runs. No issue was found. Thanks for running the tests.

KateFriedman-NOAA commented 1 year ago

@KateFriedman-NOAA I compared the output files on Orion. The records are identical from the two runs. No issue was found. Thanks for running the tests.

Thanks for checking the outputs @BoCui-NOAA ! I will proceed with approving this PR.