NOAA-EMC / gfs-utils

Utility programs for global-workflow

0 stars 15 forks source link

RDHPCS Hera Rocky-8 updates #58

Closed HenryRWinterbottom closed 3 months ago

HenryRWinterbottom commented 3 months ago

Description

This PR addresses global workflow issue #2329. The following is accomplished:

The stack against which GFS-utils is build is updated to spack-stack compliant with the Rocky-8 upgrade for RDHPCS Hera.

Resolves #49 Refs #2329

Type of change

New feature (adds functionality)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

The relevant global-workflow applications which exercise the relevant GFS utils applications have passed on RDHPCS Hera.

Checklist

[x] Any dependent changes have been merged and published
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing tests pass with my changes
[x] I have made corresponding changes to the documentation if necessary

HenryRWinterbottom commented 3 months ago

Changes look good for the main Intel module file, but the rdbfmsua module file should also be updated:

https://github.com/NOAA-EMC/gfs-utils/blob/ad6592f6d723bcb32b45bddadc427577f193622e/modulefiles/rdbfmsua_hera.intel.lua#L5

Done.