NOAA-EMC / gfs-utils

Utility programs for global-workflow

0 stars 19 forks source link

Change GRIB2 parameter names and vertical levels for nc2grb #70

Closed GwenChen-NOAA closed 4 months ago

GwenChen-NOAA commented 4 months ago

Description

Based on users' feedback, this PR do the following:

Change GRIB2 parameter names DLWRF -> NLWRF and DSWRF -> NSWRF
Change the vertical level of ocean 3D variables (WTMP, SALIN, UOGRD, and VOGRD) from "%g m below water surface" to "%g m below sea level"
Round up depth numbers to integer (e.g. 4481.0625 -> 4481 m)

Type of change

Update

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

Tested on WCOSS2 using sample netcdf files and successfully generated grib2 files.

Checklist

[X] Any dependent changes have been merged and published
[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings
[X] New and existing tests pass with my changes
[ ] I have made corresponding changes to the documentation if necessary

aerorahul commented 4 months ago

@GwenChen-NOAA These scripts (in gfs-utils) are no longer used in the GFS/GEFS. They will be removed in the future to eliminate this duplication. The scripts are in the global-workflow and you have updated them in https://github.com/NOAA-EMC/global-workflow/pull/2611.