NOAA-EMC / gfs-utils

Utility programs for global-workflow

0 stars 19 forks source link

Update modules on orion for rocky 8 #72

Closed aerorahul closed 3 months ago

aerorahul commented 3 months ago

Description

This PR:

updates modulefile for Orion to the Rocky8 OS upgrade
gempak module is not available on Orion+Rocky8 after the upgrade. rdbfmsua.x will not be built.

Type of change

Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? YES (rdbfmsua.x is no longer built on orion due to gempak unavailability)
Does this change require a documentation update? YES (if there is any)

How has this been tested?

build tested on Orion

Checklist

[ ] Any dependent changes have been merged and published
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] New and existing tests pass with my changes
[ ] I have made corresponding changes to the documentation if necessary

DavidHuber-NOAA commented 3 months ago

Detect machine also needs to be updated as both Orion and Hercules now have /apps/other. Suggest changing https://github.com/NOAA-EMC/gfs-utils/blob/6df304f6f09006593643a5a1a890e1f940132cb5/ush/detect_machine.sh#L76-L83

to the same as the GSI:

 elif [[ -d /work ]]; then 
  mount=$(findmnt -n -o SOURCE /home)
  if [[ ${mount} =~ "hercules" ]]; then
    MACHINE_ID=hercules
  else
    MACHINE_ID=orion
  fi