search

NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
75 stars 168 forks source link

Clean up parm/parm_wave directory and script input files #1244

Open JessicaMeixner-NOAA opened 1 year ago

JessicaMeixner-NOAA commented 1 year ago

Description This is a low-priority clean-up issue. The files in parm/parm_wave only differ based on one or two things: either forecast hour or grid features. There's no need for so many files, however care must be taken to have the correct format in the end. Note files could change in the future.

Requirements Less files

Acceptance Criteria (Definition of Done) We have less files and script the parm/parm_wave/* files to have less files and less oppertunity for mistakes if changes are made.

Dependencies None.

arunchawla-NOAA commented 1 year ago

@JessicaMeixner-NOAA what help do you need?

JessicaMeixner-NOAA commented 1 year ago

This is very low priority, but if we wanted to clean up the parm/parm_wave directory, we could have either 1 or number of grid template files to be used instead of (# of output grids)x(# of forecast hours) files - which are used here: https://github.com/NOAA-EMC/global-workflow/blob/develop/scripts/exgfs_wave_prdgen_gridded.sh

It's okay if it doesn't happen, but I made that issue (I believe at @aerorahul's request) so we could keep track of this.

arunchawla-NOAA commented 1 year ago

we should clearly get rid of the old grids. As for grib2 header files, these were created for the different forecast hours from Boi. Perhaps we can have a smarter way of doing this

JessicaMeixner-NOAA commented 1 year ago

I don't think we currently have any old grids in there right now, but we likely will need changes for GFSv17 just not sure exactly what that will be at this moment.