search

NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
70 stars 163 forks source link

need to update checkout.sh to use the latest model hash #189

Closed yangfanglin closed 3 years ago

yangfanglin commented 3 years ago

See https://github.com/ufs-community/ufs-weather-model/pull/274 for the latest model updates. It uses an updated UPP lib that has a correction of CAPE computation.

checkout.sh needs to be updated to check out model hash b771e5be7e35eaea5ee7f762d644afccab019ed3

yangfanglin commented 3 years ago

Kate, I have run a forecast-only case with the new hash on HERA last night. Are more tests needed ? I can update check.sh and commit to "develop" without any more testing if you feel comfortable with this approach. Otherwise I will let you assign this task to someone to run more tests.

KateFriedman-NOAA commented 3 years ago

@yangfanglin Given this introduces a correction and is confined to just the fcst jobs I am ok with this going into develop without additional tests. My only concern would be the updated code running through the efcs jobs but I don't anticipate issues there.

Please submit a PR with the change to develop and I'll submit it when I see the notification come through. I have GitHub alerts turned on on my phone and can submit from there if I see it after I leave the house. Thanks!

KateFriedman-NOAA commented 3 years ago

@yangfanglin Are you still looking to update the develop checkout.sh hash for ufs-weather-model?

yangfanglin commented 3 years ago

Kate, Please update the hash to b771e5be7e35eaea5ee7f762d644afccab019ed3, which has been shown to be able to reproduce gfs.v16 results and maintain restart reproducibility. The "develop" branch needs more tests.

On Tue, Dec 15, 2020 at 10:20 AM Kate Friedman notifications@github.com wrote:

@yangfanglin https://github.com/yangfanglin Are you still looking to update the develop checkout.sh hash for ufs-weather-model?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/global-workflow/issues/189#issuecomment-745360246, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKY5N2NSV4TPZNZG4XBMLS3SU55B7ANCNFSM4TZO4OPA .

-- Fanglin Yang, Ph.D. Chief, Model Physics Group Modeling and Data Assimilation Branch

NOAA/NWS/NCEP Environmental Modeling Center

https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/ https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/