NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
70 stars 162 forks source link

Updates ocean files in gdasarch #2594

Closed AndrewEichmann-NOAA closed 1 month ago

AndrewEichmann-NOAA commented 1 month ago

Description

Fixes bug where ocean history files are not archived.

Resolves https://github.com/NOAA-EMC/GDASApp/issues/1105

Type of change

Change characteristics

How has this been tested?

Not tested, would require cycling test. Will be tested in ongoing experiment

Checklist

AndrewEichmann-NOAA commented 1 month ago

FYI @guillaumevernieres @KatherineLukens-NOAA Katie you can hand-patch this in to your build

WalterKolczynski-NOAA commented 1 month ago

2491 seems imminent. Do we need to deal with this immediately, or can we just wait for that?

AndrewEichmann-NOAA commented 1 month ago

2491 seems imminent. Do we need to deal with this immediately, or can we just wait for that?

I think we're ok - @KatherineLukens-NOAA patched manually.

AndrewEichmann-NOAA commented 1 month ago

@CatherineThomas-NOAA @JessicaMeixner-NOAA Guillaume thought you might want to know about this

aerorahul commented 1 month ago

@DavidHuber-NOAA Can you include the changes in this PR into #2621 The file that this PR is modifying no longer exists.

DavidHuber-NOAA commented 1 month ago

@aerorahul This was actually captured in #2491 (here). There are some other ocean archiving issues I'm working through with @AndrewEichmann-NOAA and @guillaumevernieres in #2621, but they are separate from this particular PR, so I think this can be closed.

aerorahul commented 1 month ago

OBE