NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)

https://global-workflow.readthedocs.io/en/latest

GNU Lesser General Public License v3.0

70 stars 162 forks source link

Update gsi_utils.fd hash #2598

Closed RussTreadon-NOAA closed 1 month ago

RussTreadon-NOAA commented 1 month ago

Description

This PR updates the gsi_utils.fd hash to bring in updates which add safeguards to

src/EnKF/gfs/src/getsigensmeanp_smooth.fd/getsigensmeanp_smooth_ncep.f90
src/EnKF/gfs/src/recentersigp.fd/recentersigp.f90

The safeguards are described in GSI-utils PR #41 and the associated issue.

Resolves #2597

Type of change

Maintenance - update submodule hash

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

[x] Clone, build, and cycle on Orion

Checklist

[x] Any dependent changes have been merged and published
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code

RussTreadon-NOAA commented 1 month ago

C96C48_hybatmDA (GSI-based DA) and C96C48_ufs_hybatmDA (JEDI-based DA) CI initiated on Orion. Initial half-cycle is complete. DA jobs for the first full cycle are complete. Only the gfs forecast remains running for the first full cycle. The second full cycle for GSI-based DA has begun. JEDI-based DA does not run a second full cycle.

Change this PR to Ready for review

emcbot commented 1 month ago


CI Update on Wcoss2 at 05/14/24 09:32:14 PM
============================================
Cloning and Building global-workflow PR: 2598
with PID: 190366 on host: clogin05

emcbot commented 1 month ago

Automated global-workflow Testing Results:


Machine: Wcoss2
Start: Tue May 14 21:39:36 UTC 2024 on clogin05
---------------------------------------------------
Build: Completed at 05/14/24 09:50:59 PM
Case setup: Completed for experiment C48_ATM_9e46637d
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_9e46637d
Case setup: Skipped for experiment C48_S2SWA_gefs_9e46637d
Case setup: Completed for experiment C48_S2SW_9e46637d
Case setup: Completed for experiment C96_atm3DVar_extended_9e46637d
Case setup: Skipped for experiment C96_atm3DVar_9e46637d
Case setup: Skipped for experiment C96_atmaerosnowDA_9e46637d
Case setup: Completed for experiment C96C48_hybatmDA_9e46637d
Case setup: Skipped for experiment C96C48_ufs_hybatmDA_9e46637d

emcbot commented 1 month ago

Experiment C48_ATM_9e46637d SUCCESS on Wcoss2 at 05/14/24 11:27:12 PM

RussTreadon-NOAA commented 1 month ago

Run second set of GSI and JEDI based CI tests using current head of g-w develop. Compare atmf006.nc files from last cycle with those from GSI and JEDI CI tests using feature/gsi_utils. Forecasts are identical. As expected, the changes in this PR do not alter cycled results.

emcbot commented 1 month ago

Experiment C48_S2SW_9e46637d SUCCESS on Wcoss2 at 05/14/24 11:57:12 PM

emcbot commented 1 month ago

Experiment C96C48_hybatmDA_9e46637d SUCCESS on Wcoss2 at 05/15/24 12:18:17 AM

emcbot commented 1 month ago

CI Passed Orion at
Built and ran in directory /work2/noaa/stmp/CI/ORION/2598

emcbot commented 1 month ago

CI Passed Hera at
Built and ran in directory /scratch1/NCEPDEV/global/CI/2598

emcbot commented 1 month ago

Experiment C96_atm3DVar_extended_9e46637d SUCCESS on Wcoss2 at 05/15/24 05:51:26 AM

emcbot commented 1 month ago

All CI Test Cases Passed on Wcoss2:


Experiment C48_ATM_9e46637d *** SUCCESS *** at 05/14/24 11:27:12 PM
Experiment C48_S2SW_9e46637d *** SUCCESS *** at 05/14/24 11:57:12 PM
Experiment C96C48_hybatmDA_9e46637d *** SUCCESS *** at 05/15/24 12:18:17 AM
Experiment C96_atm3DVar_extended_9e46637d *** SUCCESS *** at 05/15/24 05:51:26 AM

TerrenceMcGuinness-NOAA commented 1 month ago

All CI Cases passed on Hercules:

Not sure why Label and reporting failed. The Controler removed the run record. I'm going to increase the number retained runs on the project and update the label to PASSED by hand.

mterry (hercules-login-1) EXPDIR $ pwd
/work2/noaa/stmp/CI/HERCULES/2598/RUNTESTS/EXPDIR

mterry (hercules-login-1) EXPDIR $ ll
total 60K
drwxr-s--- 3 mterry stmp  12K May 14 18:11 C48_ATM_9e46637d
drwxr-s--- 4 mterry stmp 4.0K May 14 18:11 ..
drwxr-s--- 7 mterry stmp 4.0K May 14 18:12 .
drwxr-s--- 3 mterry stmp  12K May 14 19:54 C96C48_hybatmDA_9e46637d
drwxr-s--- 3 mterry stmp  12K May 14 20:22 C96_atm3DVar_9e46637d
drwxr-s--- 3 mterry stmp 4.0K May 14 21:59 C48_S2SWA_gefs_9e46637d
drwxr-s--- 3 mterry stmp  12K May 14 23:55 C48_S2SW_9e46637d

mterry (hercules-login-1) EXPDIR $ cat ../ci-run_check.log 
Experiment C48_ATM_9e46637d Completed 1 Cycles at Tue May 14 18:11:57 CDT 2024
with 20 successfully completed jobs
Experiment C48_ATM_9e46637d Completed: *SUCCESS*
Experiment C96C48_hybatmDA_9e46637d Completed 3 Cycles at Tue May 14 19:54:37 CDT 2024
with 120 successfully completed jobs
Experiment C96C48_hybatmDA_9e46637d Completed: *SUCCESS*
Experiment C96_atm3DVar_9e46637d Completed 3 Cycles at Tue May 14 20:22:43 CDT 2024
with 62 successfully completed jobs
Experiment C96_atm3DVar_9e46637d Completed: *SUCCESS*
Experiment C48_S2SWA_gefs_9e46637d Completed 1 Cycles at Tue May 14 21:59:43 CDT 2024
with 216 successfully completed jobs
Experiment C48_S2SWA_gefs_9e46637d Completed: *SUCCESS*
Experiment C48_S2SW_9e46637d Completed 1 Cycles at Tue May 14 23:55:49 CDT 2024
with 37 successfully completed jobs
Experiment C48_S2SW_9e46637d Completed: *SUCCESS*