NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
70 stars 162 forks source link

Fold in obsproc/v1.2 and WDQMS script error handling updates #2603

Closed KateFriedman-NOAA closed 1 month ago

KateFriedman-NOAA commented 1 month ago

Description

This PR merges in updates for obsproc/v1.2 (from the release/gfs.v16.3.15 branch) and an update to scripts/exgdas_atmos_analysis_wdqms.sh error handling per discussion with NCO (SPA Simon).

@emilyhcliu FYI about additional script error handling update. SPA Simon requested this final edit to conform with NCO error handling standards. He approved of your prior updates, so this should be the last script update.

Will merge and recut final hand-off tag for NCO install.

Refs #2389

Type of change

Feedback from NCO and prior version change merge in.

Change characteristics

How has this been tested?

By NCO in para

emilyhcliu commented 1 month ago

@KateFriedman-NOAA The use of ObsProc v1.2 in the global workflow causes issues in WDQMS processing for radiosonde data. ObsProc v1.2 includes high-resolution radiosonde data. At some stations, multiple observations for the same location (lat, long, pressure) and time are made, which contains mostly bad data and causes problems in WDQMS processing.

The issue I described above does not occur for ObsProc v1.1. We are working on a solution for WDQMS to handle the issue. Therefore, this will not be the final cut to NCO.

KateFriedman-NOAA commented 1 month ago

We are working on a solution for WDQMS to handle the issue. Therefore, this will not be the final cut to NCO.

@emilyhcliu Understood, thanks for those details! I had a feeling this wouldn't be the end lol :)