Add IAU to snow DA (and its test)

[CoryMartin-NOAA]

Description

This PR enables IAU for the snow DA which is necessary for GFSv17.

A snow analysis is created for the center of the window regardless, and an additional at the beginning of the window is added if IAU is on. The former is needed for UPP and the latter, to initialize the model.

The increment is valid throughout the window for 3DVar, so the same increment is added to both forecasts.

Additionally, the input file that goes into global_cycle has been updated to be the output of the JEDI snow analysis instead of the forecast (@jiaruidong2017 I recall discussing this, can you confirm this is right or am I mistaken)

This PR also makes the CI test for snow DA (and aerosol DA) include IAU rather than without IAU,.

Type of change

• New feature (adds functionality)

Change characteristics

• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO

How has this been tested?

Example:

• Clone and build on Hera
• Cycled test on Hera, very briefly though and would like @jiaruidong2017 to test it out when he has time

Checklist

• [x] Any dependent changes have been merged and published
• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] My changes generate no new warnings
• [ ] New and existing tests pass with my changes
• [x] I have made corresponding changes to the documentation if necessary

[emcbot]

Experiment C48_ATM_3e5eea69 SUCCESS on Wcoss2 at 06/03/24 06:03:25 PM

[emcbot]

Experiment C48_S2SW_3e5eea69 SUCCESS on Wcoss2 at 06/03/24 06:06:21 PM

[emcbot]

Experiment C96C48_hybatmDA_3e5eea69 SUCCESS on Wcoss2 at 06/03/24 06:51:26 PM

[emcbot]

Experiment C96_atm3DVar_extended_3e5eea69 SUCCESS on Wcoss2 at 06/04/24 12:33:31 AM

[emcbot]

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_3e5eea69 *** SUCCESS *** at 06/03/24 06:03:25 PM
Experiment C48_S2SW_3e5eea69 *** SUCCESS *** at 06/03/24 06:06:21 PM
Experiment C96C48_hybatmDA_3e5eea69 *** SUCCESS *** at 06/03/24 06:51:26 PM
Experiment C96_atm3DVar_extended_3e5eea69 *** SUCCESS *** at 06/04/24 12:33:31 AM

[WalterKolczynski-NOAA]

@WalterKolczynski-NOAA this one test on WCOSS is only ran there, right? what is unique about it compared to the other CI tests. @aerorahul I fear the issue is (without any evidence) related to the IAU valid time in global_cycle, because it runs successfully for the center of the window, but not the beginning.

For future reference, since it looks like it was fixed: The extended test is a longer/more complete version of the regular 3dvar atm test. It:

• Runs 4½ cycles instead of 1½
• Runs the full 384 hours
• Runs the secondary product jobs (gempak, sounding, etc.)

That first is probably what uncovered the flaw that was missed on other machines.

[emcbot]

CI Passed Orion at
Built and ran in directory /work2/noaa/stmp/CI/ORION/2610

[CoryMartin-NOAA]

it definitely did uncover that bug, thanks @WalterKolczynski-NOAA for the explanation