NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
70 stars 162 forks source link

Change GRIB2 parameter names and vertical levels for ocean/ice post #2611

Closed GwenChen-NOAA closed 1 month ago

GwenChen-NOAA commented 1 month ago

Description

Based on users' feedback, this PR do the following:

  1. Change GRIB2 parameter names DLWRF -> NLWRF and DSWRF -> NSWRF
  2. Change the vertical level of ocean 3D variables (WTMP, SALIN, UOGRD, and VOGRD) from "%g m below water surface" to "%g m below sea level"
  3. Round up depth numbers to integer (e.g. 4481.0625 -> 4481 m)

Type of change

Change characteristics

How has this been tested?

Tested on WCOSS2 using nc2grb scripts.

Checklist

GwenChen-NOAA commented 1 month ago

looks ok to me. just one note on some of the variables that were ??? were commented out and still are. Some other variables that were renamed e.g. ALBICE are still commented out.

These variables are not available in wgrib2 v2.0.8. They will be added in another update.

WalterKolczynski-NOAA commented 1 month ago

@GwenChen-NOAA Please merge in develop to get the CI fixes, then I think we are ready for CI testing.

GwenChen-NOAA commented 1 month ago

@GwenChen-NOAA Please merge in develop to get the CI fixes, then I think we are ready for CI testing.

Just did.

emcbot commented 1 month ago

CI Update on Wcoss2 at 05/24/24 06:44:11 PM
============================================
Cloning and Building global-workflow PR: 2611
with PID: 141764 on host: clogin01
emcbot commented 1 month ago

Automated global-workflow Testing Results:


Machine: Wcoss2
Start: Fri May 24 18:52:20 UTC 2024 on clogin01
---------------------------------------------------
Build: Completed at 05/24/24 07:03:48 PM
Case setup: Completed for experiment C48_ATM_04f2dd1f
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_04f2dd1f
Case setup: Skipped for experiment C48_S2SWA_gefs_04f2dd1f
Case setup: Completed for experiment C48_S2SW_04f2dd1f
Case setup: Completed for experiment C96_atm3DVar_extended_04f2dd1f
Case setup: Skipped for experiment C96_atm3DVar_04f2dd1f
Case setup: Skipped for experiment C96_atmaerosnowDA_04f2dd1f
Case setup: Completed for experiment C96C48_hybatmDA_04f2dd1f
Case setup: Skipped for experiment C96C48_ufs_hybatmDA_04f2dd1f
aerorahul commented 1 month ago

Running the CI is no use here since we know its going to give all zeros.

emcbot commented 1 month ago

Experiment C48_S2SWA_gefs FAILED on Orion with error logs:

/work2/noaa/stmp/CI/ORION/2611/RUNTESTS/COMROOT/C48_S2SWA_gefs_04f2dd1f/logs/2021032312/ocean_prod_mem000_f018.log
/work2/noaa/stmp/CI/ORION/2611/RUNTESTS/COMROOT/C48_S2SWA_gefs_04f2dd1f/logs/2021032312/ocean_prod_mem001_f012.log
/work2/noaa/stmp/CI/ORION/2611/RUNTESTS/COMROOT/C48_S2SWA_gefs_04f2dd1f/logs/2021032312/ocean_prod_mem002_f006.log

Follow link here to view the contents of the above file(s): (link)

emcbot commented 1 month ago

Experiment C48_S2SWA_gefs FAILED on Orion in /work2/noaa/stmp/CI/ORION/2611/RUNTESTS/C48_S2SWA_gefs_04f2dd1f

emcbot commented 1 month ago

Experiment C48_ATM_04f2dd1f SUCCESS on Wcoss2 at 05/24/24 08:48:15 PM

emcbot commented 1 month ago

Experiment C48_S2SW_04f2dd1f SUCCESS on Wcoss2 at 05/24/24 09:33:13 PM

emcbot commented 1 month ago

Experiment C96C48_hybatmDA FAILED on Orion with error logs:

/work2/noaa/stmp/CI/ORION/2611/RUNTESTS/COMROOT/C96C48_hybatmDA_04f2dd1f/logs/2021122100/gfsatmos_prod_f099-f105.log

Follow link here to view the contents of the above file(s): (link)

emcbot commented 1 month ago

Experiment C96C48_hybatmDA FAILED on Orion in /work2/noaa/stmp/CI/ORION/2611/RUNTESTS/C96C48_hybatmDA_04f2dd1f

emcbot commented 1 month ago

Experiment C96C48_hybatmDA_04f2dd1f SUCCESS on Wcoss2 at 05/24/24 11:00:30 PM

emcbot commented 1 month ago

CI Passed Hercules at
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2611

emcbot commented 1 month ago

Experiment C96_atm3DVar_extended_04f2dd1f SUCCESS on Wcoss2 at 05/25/24 05:57:32 AM

emcbot commented 1 month ago

All CI Test Cases Passed on Wcoss2:


Experiment C48_ATM_04f2dd1f *** SUCCESS *** at 05/24/24 08:48:15 PM
Experiment C48_S2SW_04f2dd1f *** SUCCESS *** at 05/24/24 09:33:13 PM
Experiment C96C48_hybatmDA_04f2dd1f *** SUCCESS *** at 05/24/24 11:00:30 PM
Experiment C96_atm3DVar_extended_04f2dd1f *** SUCCESS *** at 05/25/24 05:57:32 AM
emcbot commented 1 month ago

CI Passed Orion at
Built and ran in directory /work2/noaa/stmp/CI/ORION/2611

emcbot commented 1 month ago

CI Passed Hera at
Built and ran in directory /scratch1/NCEPDEV/global/CI/2611