NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)

https://global-workflow.readthedocs.io/en/latest

GNU Lesser General Public License v3.0

70 stars 162 forks source link

Update to add 1-deg global wave grid #2619

Closed JessicaMeixner-NOAA closed 1 month ago

JessicaMeixner-NOAA commented 1 month ago

Description

This PR adds options to use a global 1 deg grid, intended for testing with the SFS applicaiton.

Requires new fix file chnages https://github.com/NOAA-EMC/global-workflow/issues/2618

Type of change

New feature - new wave grid option

Change characteristics

Is this a breaking change (a change in existing functionality)? NO

How has this been tested?

Forecast-only on Hera, GEFS with 1 enemble member: /scratch1/NCEPDEV/climate/Jessica.Meixner/SFS/testwave02/sfs06/sfs06/ Note this was tested with @NeilBarton-NOAA branch + some updates that shouldn't be used in develop, but this did test that the grid and mesh file were as expected.

Checklist

[ ] Any dependent changes have been merged and published
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] New and existing tests pass with my changes
[ ] I have made corresponding changes to the documentation if necessary

WalterKolczynski-NOAA commented 1 month ago

Marking as draft until the prerequisite fix files have been staged.

WalterKolczynski-NOAA commented 1 month ago

@JessicaMeixner-NOAA Please merge in develop to get the CI fixes, then I think we are ready for CI testing.

JessicaMeixner-NOAA commented 1 month ago

@WalterKolczynski-NOAA done! Thanks!

emcbot commented 1 month ago


CI Update on Wcoss2 at 05/28/24 06:08:07 PM
============================================
Cloning and Building global-workflow PR: 2619
with PID: 155784 on host: clogin01

emcbot commented 1 month ago

Automated global-workflow Testing Results:


Machine: Wcoss2
Start: Tue May 28 18:15:17 UTC 2024 on clogin01
---------------------------------------------------
Build: Completed at 05/28/24 06:26:20 PM
Case setup: Completed for experiment C48_ATM_b5f29179
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_b5f29179
Case setup: Skipped for experiment C48_S2SWA_gefs_b5f29179
Case setup: Completed for experiment C48_S2SW_b5f29179
Case setup: Completed for experiment C96_atm3DVar_extended_b5f29179
Case setup: Skipped for experiment C96_atm3DVar_b5f29179
Case setup: Skipped for experiment C96_atmaerosnowDA_b5f29179
Case setup: Completed for experiment C96C48_hybatmDA_b5f29179
Case setup: Skipped for experiment C96C48_ufs_hybatmDA_b5f29179

emcbot commented 1 month ago

Experiment C48_ATM_b5f29179 SUCCESS on Wcoss2 at 05/28/24 08:06:11 PM

emcbot commented 1 month ago

Experiment C48_S2SW_b5f29179 SUCCESS on Wcoss2 at 05/28/24 08:18:08 PM

emcbot commented 1 month ago

Experiment C96C48_hybatmDA_b5f29179 SUCCESS on Wcoss2 at 05/28/24 09:15:21 PM

emcbot commented 1 month ago

CI Passed Hercules at
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2619

emcbot commented 1 month ago

CI Passed Hera at
Built and ran in directory /scratch1/NCEPDEV/global/CI/2619

emcbot commented 1 month ago

Experiment C96_atm3DVar_extended_b5f29179 SUCCESS on Wcoss2 at 05/29/24 02:42:32 AM

emcbot commented 1 month ago

All CI Test Cases Passed on Wcoss2:


Experiment C48_ATM_b5f29179 *** SUCCESS *** at 05/28/24 08:06:11 PM
Experiment C48_S2SW_b5f29179 *** SUCCESS *** at 05/28/24 08:18:08 PM
Experiment C96C48_hybatmDA_b5f29179 *** SUCCESS *** at 05/28/24 09:15:21 PM
Experiment C96_atm3DVar_extended_b5f29179 *** SUCCESS *** at 05/29/24 02:42:32 AM

emcbot commented 1 month ago

CI Passed Orion at
Built and ran in directory /work2/noaa/stmp/CI/ORION/2619