Adds contents of constructor and initialize methods to marine LETKF class

[AndrewEichmann-NOAA]

Description

Adds contents of constructor and initialize methods to marine LETKF class

Partially addresses https://github.com/NOAA-EMC/GDASApp/issues/1091

Type of change

• New feature (adds functionality)

Change characteristics

• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO

How has this been tested?

Tested with GDASApp ctest on Hera

Checklist

• [x] Any dependent changes have been merged and published
• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] My changes generate no new warnings
• [x] New and existing tests pass with my changes
• [x] I have made corresponding changes to the documentation if necessary

[AndrewEichmann-NOAA]

@guillaumevernieres FYI

[aerorahul]

@CoryMartin-NOAA How does this fit in with the JEDI task design?
I note significant departure from the aerosol, snow, atm JEDI tasks.

[CoryMartin-NOAA]

@AndrewEichmann-NOAA let's chat tomorrow, I have some concerns about how variables are defined multiple times in this, in addition to the differences that @aerorahul has alluded to here

[emcbot]

CI Update on Wcoss2 at 07/10/24 02:30:08 PM
============================================
Cloning and Building global-workflow PR: 2635
with PID: 192112 on host: dlogin08

[emcbot]

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Wed Jul 10 14:33:45 UTC 2024 on dlogin08
---------------------------------------------------
Build: Completed at 07/10/24 03:12:56 PM
Case setup: Completed for experiment C48_ATM_f01fe059
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_f01fe059
Case setup: Skipped for experiment C48_S2SWA_gefs_f01fe059
Case setup: Completed for experiment C48_S2SW_f01fe059
Case setup: Completed for experiment C96_atm3DVar_extended_f01fe059
Case setup: Skipped for experiment C96_atm3DVar_f01fe059
Case setup: Completed for experiment C96_atmaerosnowDA_f01fe059
Case setup: Completed for experiment C96C48_hybatmDA_f01fe059
Case setup: Completed for experiment C96C48_ufs_hybatmDA_f01fe059

[emcbot]

CI Passed Hera at
Built and ran in directory /scratch1/NCEPDEV/global/CI/2635

Experiment C48_ATM_f01fe059 Completed 1 Cycles: *SUCCESS* at Wed Jul 10 17:08:38 UTC 2024
Experiment C48mx500_3DVarAOWCDA_f01fe059 Completed 2 Cycles: *SUCCESS* at Wed Jul 10 17:26:55 UTC 2024
Experiment C96_atm3DVar_f01fe059 Completed 3 Cycles: *SUCCESS* at Wed Jul 10 18:27:48 UTC 2024
Experiment C96C48_hybatmDA_f01fe059 Completed 3 Cycles: *SUCCESS* at Wed Jul 10 18:27:49 UTC 2024
Experiment C48_S2SW_f01fe059 Completed 1 Cycles: *SUCCESS* at Wed Jul 10 18:41:00 UTC 2024
Experiment C48_S2SWA_gefs_f01fe059 Completed 1 Cycles: *SUCCESS* at Wed Jul 10 18:54:22 UTC 2024
Experiment C96_atmaerosnowDA_f01fe059 Completed 3 Cycles: *SUCCESS* at Wed Jul 10 19:10:19 UTC 2024

[emcbot]

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_f01fe059 *** SUCCESS *** at 07/10/24 04:20:18 PM
Experiment C48_S2SW_f01fe059 *** SUCCESS *** at 07/10/24 04:32:09 PM
Experiment C96C48_hybatmDA_f01fe059 *** SUCCESS *** at 07/10/24 05:24:18 PM
Experiment C96_atmaerosnowDA_f01fe059 *** SUCCESS *** at 07/10/24 06:12:22 PM
Experiment C96C48_ufs_hybatmDA_f01fe059 *** SUCCESS *** at 07/10/24 06:40:18 PM
Experiment C96_atm3DVar_extended_f01fe059 *** SUCCESS *** at 07/11/24 03:16:33 AM

[DavidHuber-NOAA]

@AndrewEichmann-NOAA Is there a global-workflow issue for this that needs to be closed or is this only related to https://github.com/NOAA-EMC/GDASApp/issues/1091?

[AndrewEichmann-NOAA]

@DavidHuber-NOAA Evidently not - should there be?

[DavidHuber-NOAA]

No, I don't think so, since it isn't a complete solution. An issue to bring in the complete marine LETKF class and jobs may be appropriate for future PRs, though.