search

NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
70 stars 162 forks source link

Remove multi-grid wave support #2637

Open KateFriedman-NOAA opened 1 month ago

KateFriedman-NOAA commented 1 month ago

What new functionality do you need?

Removal of instances where waveGRD is a list of multiple supported wave grids. Remove related for loops (e.g. for wavGRD in ${waveGRD} ; do.

What are the requirements for the new functionality?

No more support for multi-grid waves.

Acceptance Criteria

System runs with only one value of waveGRD per instance.

@JessicaMeixner-NOAA @sbanihash FYI, please provide feedback or objections if you have any, thanks!

Suggest a solution (optional)

No response

JessicaMeixner-NOAA commented 1 month ago

@KateFriedman-NOAA, no objections as realistically we can't really run this from the global-workflow. Note this further means we cannot run v16 like set-ups in g-w (although that's already the case, just want to note it again here). One final note, is that there are places where we need loops for waveGRD that are not in support of "multi-grid" but in support of need for multiple mod_defs for post and other functionality. So just know we cannot simply grep for those loops and remove them.

I'm assuming this is a pretty low-priority issue, is that a good assumption?

KateFriedman-NOAA commented 1 month ago

@JessicaMeixner-NOAA Thank you for the feedback and notes, will keep them in mind! And yes, I don't think we're hopping on this issue immediately, just opening the issue to remember to do. Will see when a workflow developer picks it up.