JessicaMeixner-NOAA commented 2 weeks ago

Description

Updates the logic to be by run instead of for DO_JEDIOCNVAR to determine how many layers and sets the exception value for MOM6 to be 1e-34 for all scenarios. Note, we will no longer have zeros in the ocean grib output and the DA will also run without issues.

Fixes https://github.com/NOAA-EMC/global-workflow/issues/2615

Type of change

Bug fix (fixes something broken)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

(this was an earlier version): Ran a few cycles of WCDA C384mx025 /scratch1/NCEPDEV/climate/Jessica.Meixner/testmarineoutput/test01 @jiandewang @SulagnaRay-NOAA and @guillaumevernieres all have checked the output is okay.

@guillaumevernieres did tests with 1e-34 for all and DA worked as expected with this change.

Checklist

[ ] Any dependent changes have been merged and published
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] New and existing tests pass with my changes
[ ] I have made corresponding changes to the documentation if necessary

JessicaMeixner-NOAA commented 1 week ago

FYI @guillaumevernieres @CatherineThomas-NOAA @NeilBarton-NOAA @aerorahul @WalterKolczynski-NOAA

This has been updated after offline discussions and additional tests by @guillaumevernieres. The exception value for MOM6 is now 1e-34 reguardless of resolution or RUN or DOJEDI_OCN. Whether we have 40 or 75 levels in the output is now determined based on if it's GFS/GEFS - 40 and otherwise is 75 (ie gdas, etc).

emcbot commented 1 week ago


CI Update on Wcoss2 at 06/24/24 06:54:16 PM
============================================
Cloning and Building global-workflow PR: 2681
with PID: 61077 on host: dlogin08

WalterKolczynski-NOAA commented 1 week ago

Outside the scope of this PR, but why isn't the missing value being read from the metadata?

aerorahul commented 1 week ago

Outside the scope of this PR, but why isn't the missing value being read from the metadata?

Should probably update the MOM_input_template in the ufs-weather-model to fix it to -1e34 instead of making this configurable.

emcbot commented 1 week ago

Automated global-workflow Testing Results:


Machine: Wcoss2
Start: Mon Jun 24 18:58:36 UTC 2024 on dlogin08
---------------------------------------------------
Build: Completed at 06/24/24 07:35:20 PM
Case setup: Completed for experiment C48_ATM_38470299
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_38470299
Case setup: Skipped for experiment C48_S2SWA_gefs_38470299
Case setup: Completed for experiment C48_S2SW_38470299
Case setup: Completed for experiment C96_atm3DVar_extended_38470299
Case setup: Skipped for experiment C96_atm3DVar_38470299
Case setup: Skipped for experiment C96_atmaerosnowDA_38470299
Case setup: Completed for experiment C96C48_hybatmDA_38470299
Case setup: Completed for experiment C96C48_ufs_hybatmDA_38470299

WalterKolczynski-NOAA commented 1 week ago

Outside the scope of this PR, but why isn't the missing value being read from the metadata?

Nevermind, these are for writing, not reading.

emcbot commented 1 week ago

Experiment C48_ATM_38470299 SUCCESS on Wcoss2 at 06/24/24 09:04:19 PM

emcbot commented 1 week ago

Experiment C48_S2SW_38470299 SUCCESS on Wcoss2 at 06/24/24 09:12:19 PM

emcbot commented 1 week ago

Experiment C96C48_hybatmDA_38470299 SUCCESS on Wcoss2 at 06/24/24 10:24:35 PM

emcbot commented 1 week ago

Experiment C96C48_ufs_hybatmDA_38470299 SUCCESS on Wcoss2 at 06/24/24 10:40:55 PM

emcbot commented 1 week ago

Experiment C96_atm3DVar_extended_38470299 SUCCESS on Wcoss2 at 06/25/24 06:28:31 AM

emcbot commented 1 week ago

All CI Test Cases Passed on Wcoss2:


Experiment C48_ATM_38470299 *** SUCCESS *** at 06/24/24 09:04:19 PM
Experiment C48_S2SW_38470299 *** SUCCESS *** at 06/24/24 09:12:19 PM
Experiment C96C48_hybatmDA_38470299 *** SUCCESS *** at 06/24/24 10:24:35 PM
Experiment C96C48_ufs_hybatmDA_38470299 *** SUCCESS *** at 06/24/24 10:40:55 PM
Experiment C96_atm3DVar_extended_38470299 *** SUCCESS *** at 06/25/24 06:28:31 AM

TerrenceMcGuinness-NOAA commented 1 week ago

CI Tests Failed on Hera. Then GitHub failed to authenticate due to connection errors when creating the gist below for C48_ATM fail in gfsfcst.

Looks like it was a disk quota issue. We all cleared up our files on Hera yesterday upon Kate's request. Should be fine to re-run.

/bin/cp: error writing '/scratch1/NCEPDEV/stmp2/Terry.McGuinness/RUNDIRS/C48_ATM_38470299/gfsfcst.2021032312/fcst.3048188/INPUT/oro_data_ss.tile4.nc': Disk quota exceeded

https://gist.github.com/emcbot/52b58c977ed8c647a6b3e5064fd54736

emcbot commented 1 week ago

CI Passed Hercules at
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2681

NOAA-EMC / global-workflow

Update logic for MOM6 number of layers/exception values #2681

Description

Type of change

Change characteristics

How has this been tested?

Checklist