RussTreadon-NOAA
commented
1 week ago GDASApp ctests and g-w CI testing
Install RussTreadon-NOAA:feature/rename_atm at 39e719d on Dogwood, Hera, Hercules, and Orion. Run GDASApp ctests and g-w C96C48_ufs_hybatmDA.
_Note: local modifications made to C96C48_ufshybatmDA to enable CI on Hera, Hercules, and Orion.
Dogwood (WCOSS2) Not all GDASApp ctests are functional on WCOSS2 due to SLURM assumptions. This is a known issue and will be addressed by future GDASApp issue(s) and PR(s).
54% tests passed, 21 tests failed out of 46
Label Time Summary:
gdas-utils = 6.73 sec*proc (9 tests)
script = 6.73 sec*proc (9 tests)
Total Test time (real) = 172.20 sec
The following tests FAILED:
1751 - test_gdasapp_fv3jedi_fv3inc (Not Run)
1756 - test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS (Failed)
1757 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP (Failed)
1758 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT (Failed)
1759 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN (Failed)
1760 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN (Failed)
1761 - test_gdasapp_soca_copy_scratch (Failed)
1762 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT (Failed)
1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST (Failed)
1764 - test_gdasapp_soca_socahybridweights (Failed)
1765 - test_gdasapp_soca_incr_handler (Failed)
1766 - test_gdasapp_soca_ens_handler (Failed)
1769 - test_gdasapp_snow_apply_jediincr (Failed)
1770 - test_gdasapp_snow_letkfoi_snowda (Failed)
1776 - test_gdasapp_atm_jjob_var_run (Failed)
1777 - test_gdasapp_atm_jjob_var_inc (Failed)
1778 - test_gdasapp_atm_jjob_var_final (Failed)
1780 - test_gdasapp_atm_jjob_ens_run (Failed)
1781 - test_gdasapp_atm_jjob_ens_inc (Failed)
1782 - test_gdasapp_atm_jjob_ens_final (Failed)
1783 - test_gdasapp_aero_gen_3dvar_yaml (Failed)All jobs for g-w C96C48_ufs_hybatmDA CI successfully run to completion
russ.treadon@dlogin09:/lfs/h2/emc/ptmp/russ.treadon/EXPDIR/pratm> rocotostat -d pratm.db -w pratm.xml -c all -s
CYCLE STATE ACTIVATED DEACTIVATED
202402231800 Done Jun 20 2024 10:25:07 Jun 20 2024 10:40:12
202402240000 Done Jun 20 2024 10:25:07 Jun 20 2024 12:42:23Hera 48 out of 48 GDASApp ctests pass
Test project /scratch1/NCEPDEV/da/role.jedipara/git/global-workflow/rename_atm/sorc/gdas.cd/build
Start 1488: test_gdasapp_util_coding_norms
1/48 Test #1488: test_gdasapp_util_coding_norms ........................ Passed 2.47 sec
...
Start 1869: test_gdasapp_aero_gen_3dvar_yaml
48/48 Test #1869: test_gdasapp_aero_gen_3dvar_yaml ...................... Passed 0.81 sec
100% tests passed, 0 tests failed out of 48
Label Time Summary:
gdas-utils = 8.08 sec*proc (11 tests)
script = 8.08 sec*proc (11 tests)
Total Test time (real) = 2298.85 secAll jobs for g-w C96C48_ufs_hybatmDA CI successfully run to completion
Hera(hfe08):/scratch1/NCEPDEV/stmp2/role.jedipara/EXPDIR/pratm$ rocotostat -d pratm.db -w pratm.xml -c all -s
CYCLE STATE ACTIVATED DEACTIVATED
202402231800 Done Jun 20 2024 09:50:11 Jun 20 2024 10:10:13
202402240000 Done Jun 20 2024 09:50:11 Jun 20 2024 12:50:12Hercules
Initially 47 out of 48 tests passed. test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN failed because APRUN_OCNANALECEN was not defined. Examine g-w env/HERCULES.env. Find that the ocnanalecen section found in other machine env files was missing from HERCULES.env. Add an ocnanalecen section to HERCULES.env
@@ -135,6 +135,16 @@ case ${step} in
[[ ${NTHREADS_OCNANAL} -gt ${nth_max} ]] && export NTHREADS_OCNANAL=${nth_max}
export APRUN_OCNANAL="${launcher} -n ${npe_ocnanalrun} --cpus-per-task=${NTHREADS_OCNANAL}"
;;
+"ocnanalecen")
+
+ export APRUNCFP="${launcher} -n \$ncmd ${mpmd_opt}"
+
+ nth_max=$((npe_node_max / npe_node_ocnanalecen))
+
+ export NTHREADS_OCNANALECEN=${nth_ocnanalecen:-${nth_max}}
+ [[ ${NTHREADS_OCNANALECEN} -gt ${nth_max} ]] && export NTHREADS_OCNANALECEN=${nth_max}
+ export APRUN_OCNANALECEN="${launcher} -n ${npe_ocnanalecen} --cpus-per-task=${NTHREADS_OCNANALECEN}"
+;;
"ocnanalchkpt")
export APRUNCFP="${launcher} -n \$ncmd ${mpmd_opt}"Rerun ctests. This time 48 out of 48 GDASApp ctests pass
Test project /work/noaa/da/rtreadon/git/global-workflow/rename_atm/sorc/gdas.cd/build
Start 1489: test_gdasapp_util_coding_norms
1/48 Test #1489: test_gdasapp_util_coding_norms ........................ Passed 1.76 sec
...
Start 1870: test_gdasapp_aero_gen_3dvar_yaml
48/48 Test #1870: test_gdasapp_aero_gen_3dvar_yaml ...................... Passed 0.38 sec
100% tests passed, 0 tests failed out of 48
Label Time Summary:
gdas-utils = 14.93 sec*proc (11 tests)
script = 14.93 sec*proc (11 tests)
Total Test time (real) = 1637.73 secAll jobs for g-w C96C48_ufs_hybatmDA CI successfully run to completion
hercules-login-3:/work/noaa/stmp/rtreadon/EXPDIR/pratm$ rocotostat -d pratm.db -w pratm.xml -c all -s
CYCLE STATE ACTIVATED DEACTIVATED
202402231800 Done Jun 20 2024 10:00:03 Jun 20 2024 10:15:02
202402240000 Done Jun 20 2024 10:00:03 Jun 20 2024 12:05:03Orion
Add changes needed to compile GDASApp on Orion following Rocky 9 upgrade (see GDASApp PR #1180). Also found it necessary to update g-w workflow/hosts.py and ush/detect_machine.sh (see g-w issue #2695). Updated working copies of these scripts accordingly. After this 48 out of 48 GDASApp ctests pass
Test project /work2/noaa/da/rtreadon/git/global-workflow/rename_atm/sorc/gdas.cd/build
Start 1489: test_gdasapp_util_coding_norms
1/48 Test #1489: test_gdasapp_util_coding_norms ........................ Passed 6.23 sec
...
Start 1870: test_gdasapp_aero_gen_3dvar_yaml
48/48 Test #1870: test_gdasapp_aero_gen_3dvar_yaml ...................... Passed 7.02 sec
100% tests passed, 0 tests failed out of 48
Label Time Summary:
gdas-utils = 39.30 sec*proc (11 tests)
script = 39.30 sec*proc (11 tests)
Total Test time (real) = 1715.61 secNo attempt was made to run g-w C96C48_ufs_hybatmDA CI because g-w has not yet been updated to run on Orion following the Rocky 9 upgrade (see g-w issue #2694)
guillaumevernieres
aerorahul
DavidNew-NOAA
emcbot
CoryMartin-NOAA
TerrenceMcGuinness-NOAA
KateFriedman-NOAA
Description
This PR updates the
gdas.cdhash to bring in new JCB conventions. Resolves #2699From #2654 This PR will move much of the staging code that take place in the python initialization subroutines of the variational and ensemble DA jobs into Jinja2-templated YAML files to be passed into the wxflow file handler. Much of the staging has already been done this way, but this PR simply expands that strategy.
The old Python routines that were doing this staging are now removed. This is part of a broader refactoring of the pygfs tasking.
wxflow PR #30 is a companion to this PR.
Type of change
gdas.cdhash)Change characteristics
How has this been tested?
Checklist