NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)

https://global-workflow.readthedocs.io/en/latest

GNU Lesser General Public License v3.0

70 stars 161 forks source link

Revert PR 2681 #2739

Closed aerorahul closed 2 days ago

aerorahul commented 2 days ago

Description

This PR:

reverts #2681 in part
keeps some changes for RUN.
is a hotfix
should be merged ASAP after consensus w/ @guillaumevernieres @CatherineThomas-NOAA @WalterKolczynski-NOAA

Type of change

Bug fix (fixes something broken)

Checklist

[ ] Any dependent changes have been merged and published
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] New and existing tests pass with my changes
[ ] I have made corresponding changes to the documentation if necessary

JessicaMeixner-NOAA commented 2 days ago

FYI - My C48mx500 WCDA test succeeded with this branch: /scratch1/NCEPDEV/climate/Jessica.Meixner/tryagainocnpost/testciC48mx500wcda/

C384 test is not far enough along to check yet

aerorahul commented 2 days ago

I don't know what GH is checking for here Screenshot 2024-06-28 at 2 38 32 PM

RussTreadon-NOAA commented 2 days ago

I copied the config.ufs from JessicaMeixner-NOAA:feature/updatefillvalues at ff74f8e6 to Hera /scratch1/NCEPDEV/stmp2/Russ.Treadon/EXPDIR/pr2700_wcda. The 20210324 18Z gdasfcst was rewound and rebooted. The model failed in the same way it did before.

Do we need to back up the 20210324 12Z start of C48mx500_3DVarAOWCDA and rerun from the first half-cycle gdasfcst?

JessicaMeixner-NOAA commented 2 days ago

I copied the config.ufs from JessicaMeixner-NOAA:feature/updatefillvalues at ff74f8e to Hera /scratch1/NCEPDEV/stmp2/Russ.Treadon/EXPDIR/pr2700_wcda. The 20210324 18Z gdasfcst was rewound and rebooted. The model failed in the same way it did before.

Do we need to back up the 20210324 12Z start of C48mx500_3DVarAOWCDA and rerun from the first half-cycle gdasfcst?

@guillaumevernieres - can you confirm, but I'm thinking you will because this will effect output from the first gdas forecast half cycle.

AndrewEichmann-NOAA commented 2 days ago

I copied the config.ufs from JessicaMeixner-NOAA:feature/updatefillvalues at ff74f8e to Hera /scratch1/NCEPDEV/stmp2/Russ.Treadon/EXPDIR/pr2700_wcda. The 20210324 18Z gdasfcst was rewound and rebooted. The model failed in the same way it did before. Do we need to back up the 20210324 12Z start of C48mx500_3DVarAOWCDA and rerun from the first half-cycle gdasfcst?

@guillaumevernieres - can you confirm, but I'm thinking you will because this will effect output from the first gdas forecast half cycle.

We ran the WCDA-3DVAR-C48mx500 test with this reversion and got physical number back in the increments.

guillaumevernieres commented 2 days ago

I copied the config.ufs from JessicaMeixner-NOAA:feature/updatefillvalues at ff74f8e to Hera /scratch1/NCEPDEV/stmp2/Russ.Treadon/EXPDIR/pr2700_wcda. The 20210324 18Z gdasfcst was rewound and rebooted. The model failed in the same way it did before. Do we need to back up the 20210324 12Z start of C48mx500_3DVarAOWCDA and rerun from the first half-cycle gdasfcst?

@guillaumevernieres - can you confirm, but I'm thinking you will because this will effect output from the first gdas forecast half cycle.

@RussTreadon-NOAA , you need to reboot the entire test, starting from the first 1/2 cycle.

RussTreadon-NOAA commented 2 days ago

Thank you @guillaumevernieres . I've done so and C48mx500_3DVarAOWCDA is almost back up to the 18Z gdasfcst.