NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
75 stars 168 forks source link

Remove atmos_prod f000 rocoto task when OFFSET_START_HOUR is greater than 0 #2771

Closed EricSinsky-NOAA closed 3 months ago

EricSinsky-NOAA commented 4 months ago

What is wrong?

When OFFSET_START_HOUR is greater than 0, the atmos_prod f000 task is still added as a rocoto task. This is an issue because if the OFFSET_START_HOUR is greater than 0, then the atmos_prod f000 task will never be triggered, which results in a stalled atmos_prod task. This may cause downstream tasks to never be triggered, particularly tasks that depend on all lead times to complete for the atmosphere component.

What should have happened?

The atmos_prod f000 task should be removed when OFFSET_START_HOUR is greater than 0.

What machines are impacted?

All or N/A

Steps to reproduce

  1. Set REPLAY_ICS to YES.
  2. Set OFFSET_START_HOUR to a value greater than 0.
  3. Make sure atmos is included as a component.

Additional information

Below is a screenshot of an example of the atmos_prod f000 task not being triggered. In this example, OFFSET_START_HOUR is 3.

Screenshot from 2024-07-17 15-22-16

Do you have a proposed solution?

One possible solution is to have an FHMIN specifically for the atmosphere, such as FHMIN_ATMOS. It should be noted that the wave component has its own FHMIN, which is called FHMIN_WAV. When OFFSET_START_HOUR is greater than 0, FHMIN_ATMOS should be set to OFFSET_START_HOUR, while the FHMIN for the ocean and ice should be 0.

EricSinsky-NOAA commented 4 months ago

It looks like there is already an FHMIN variable for the atmosphere called FHMIN_GFS. However, it appears FHMIN is being used in the forecast_predet and forecast_postdet scripts. FHMIN is being used for atmosphere, ocean and ice. For the atmosphere-related functions in predet and postdet, I think FHMIN can be replaced with FHMIN_GFS.