NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
71 stars 163 forks source link

Remove goto statements from GFS package #292

Open WalterKolczynski-NOAA opened 3 years ago

WalterKolczynski-NOAA commented 3 years ago

This is a tracking issue to monitor the progress of goto statement removal from packages used by global-workflow. This issue should link to the corresponding GitHub issues in the offending packages to ensure all are addressing this issue.

As of 16.0.7, here is the goto count reported by NCO:

global-workflow codes:

Component codes:

Total: 3037

Refs: Bugzilla #216

WalterKolczynski-NOAA commented 8 months ago

Current develop:

gfs_utils.fd: 20
gsi_enkf.fd: 7
gsi_monitor.fd: 2
gsi_utils.fd: 31
ufs_model.fd: 529
ufs_utils.fd: 75
WalterKolczynski-NOAA commented 8 months ago

Further breakdown for UFS (a few are false-positives):

(gfs_workflow) Orion-login-3 ufs_model.fd/>for dir in *; do echo "$dir: $(grep -oR goto $dir | wc -l)"; done | grep -v ": 0"
AQM: 36
CDEPS-interface: 2
CICE-interface: 141
doc: 2
FV3: 137
GOCART: 2
HYCOM-interface: 54
MOM6-interface: 4
NOAHMP-interface: 3
stochastic_physics: 5
WW3: 143