NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)

https://global-workflow.readthedocs.io/en/latest

GNU Lesser General Public License v3.0

75 stars 170 forks source link

Update JGDAS ENKF SELECT OBS JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs #3092

Open mingshichen-noaa opened 2 weeks ago

mingshichen-noaa commented 2 weeks ago

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jgdas enkf select obs job and relevant .JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs.

Refs https://github.com/NOAA-EMC/global-workflow/issues/2451

Type of change

Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

Clone and build on RDHPCS
Cycled tests on Hercules
Forecast-only tests on Hercules

Checklist

[x] Any dependent changes have been merged and published
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing tests pass with my changes
[x] I have made corresponding changes to the documentation if necessary

emcbot commented 2 weeks ago

Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmDA_01216a52/logs/2021122100/enkfgdas_eobs.log

Follow link here to view the contents of the above file(s): (link)

emcbot commented 2 weeks ago

Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 in /scratch1/NCEPDEV/global/CI/3092/RUNTESTS/EXPDIR/C96C48_hybatmDA_01216a52

emcbot commented 2 weeks ago

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_01216a52/logs/2021122018/enkfgdas_eobs.log

Follow link here to view the contents of the above file(s): (link)

emcbot commented 2 weeks ago

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 in /scratch1/NCEPDEV/global/CI/3092/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_01216a52

emcbot commented 2 weeks ago

CI Failed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3092



Experiment C96C48_hybatmDA_01216a52 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Nov 15 10:31:28 UTC 2024
Experiment C96C48_hybatmDA_01216a52 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmDA_01216a52/logs/2021122100/enkfgdas_eobs.log
Experiment C96C48_hybatmaerosnowDA_01216a52 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Nov 15 10:37:33 UTC 2024
Experiment C96C48_hybatmaerosnowDA_01216a52 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_01216a52/logs/2021122018/enkfgdas_eobs.log
Experiment C96_S2SWA_gefs_replay_ics_01216a52 Completed 1 Cycles: *SUCCESS* at Fri Nov 15 11:07:58 UTC 2024
Experiment C48_ATM_01216a52 Completed 2 Cycles: *SUCCESS* at Fri Nov 15 11:20:08 UTC 2024
Experiment C48mx500_3DVarAOWCDA_01216a52 Completed 2 Cycles: *SUCCESS* at Fri Nov 15 11:20:09 UTC 2024
Experiment C48_S2SWA_gefs_01216a52 Completed 1 Cycles: *SUCCESS* at Fri Nov 15 12:21:30 UTC 2024
Experiment C96_atm3DVar_01216a52 Completed 3 Cycles: *SUCCESS* at Fri Nov 15 12:45:34 UTC 2024
Experiment C48_S2SW_01216a52 Completed 2 Cycles: *SUCCESS* at Fri Nov 15 13:03:46 UTC 2024
Experiment C96C48_ufs_hybatmDA_01216a52 Completed 3 Cycles: *SUCCESS* at Fri Nov 15 13:22:01 UTC 2024

aerorahul commented 2 weeks ago

@mingshichen-noaa The tests failed overnight because of changes made in the j-job impacted the scripts called by the j-job.

mingshichen-noaa commented 1 week ago

@aerorahul @WalterKolczynski-NOAA @KateFriedman-NOAA Since JGDAS_ENKF_SELECT_OBS job is associated with JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSISCALC jobs, I have made changing the original COM variables into the corresponding COMIN_ or COMOUT_* variables. Please review the adding commits. Thanks in advance.

KateFriedman-NOAA commented 1 week ago

@mingshichen-noaa Since this PR now also includes COM updates for the analysis job, please update the PR title and description to reflect the file changeset. Thanks!

mingshichen-noaa commented 1 week ago

@aerorahul @KateFriedman-NOAA @AntonMFernando-NOAA Just now I checked COM to COMIN/COMOUT Tracker and found Anton planned to work on the two jobs ( JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC). Could you tell me how I should handle this case?

KateFriedman-NOAA commented 1 week ago

@aerorahul @KateFriedman-NOAA @AntonMFernando-NOAA Just now I checked COM to COMIN/COMOUT Tracker and found Anton planned to work on the two jobs ( JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC). Could you tell me how I should handle this case?

@mingshichen-noaa Thanks for checking on this! Since the change for the eobs job requires companion updates to the analysis/analysis_calc jobs at the same time then it was necessary to submit the changes together. Hopefully @AntonMFernando-NOAA hasn't already done much work on those job scripts. :)

In the future, I suggest checking the spreadsheet sooner if you think you need to update other job scripts at the same time. If someone else has already assigned themself to that job then you should reach out to them to say you can take care of it within your work or collaborate with the other developer if they have already begun making changes. Hope that helps!

KateFriedman-NOAA commented 1 week ago

@mingshichen-noaa please update the COM update tracking spreadsheet to reflect the analysis/analysis_calc job updates, thanks!

mingshichen-noaa commented 1 week ago

@KateFriedman-NOAA Thank you for your prompt reply and suggestion.

mingshichen-noaa commented 1 week ago

@KateFriedman-NOAA @AntonMFernando-NOAA I have updated https://docs.google.com/spreadsheets/d/1S4deVHNEgSR_6-q2lDOaXq4kW-4SmxurxH-q5iPVd6o/edit?pli=1&gid=0#gid=0 about

JGLOBAL_ATMOS_ANALYSIS | Mingshi | 3092 | Yes | -- | -- | -- | -- | -- JGLOBAL_ATMOS_ANALYSIS_CALC | Mingshi | 3092 | Yes |

mingshichen-noaa commented 4 days ago

@KateFriedman-NOAA After I updated the title and description of the PR (#3092), I tried to update the branch. But attempt failed and got the information: "Head branch was modified. Review and try the merge again." Could you tell me how to figure it out? Thanks in advance.

KateFriedman-NOAA commented 3 days ago

@KateFriedman-NOAA After I updated the title and description of the PR (#3092), I tried to update the branch. But attempt failed and got the information: "Head branch was modified. Review and try the merge again." Could you tell me how to figure it out? Thanks in advance.

Did you figure it out @mingshichen-noaa ? I see pushes from develop into your PR branch.

mingshichen-noaa commented 3 days ago

@KateFriedman-NOAA I have figured it out. Thanks.