NOAA-EMC / global-workflow

Global Superstructure/Workflow supporting the Global Forecast System (GFS)
https://global-workflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
74 stars 164 forks source link

Remove Theia from global-workflow #4

Closed KateFriedman-NOAA closed 4 years ago

KateFriedman-NOAA commented 4 years ago

Retire Theia from global-workflow scripts and files.

Original issue on VLab: https://vlab.ncep.noaa.gov/redmine/issues/70143

KateFriedman-NOAA commented 4 years ago

Created branch for this: feature/remove_theia

https://github.com/NOAA-EMC/global-workflow/tree/feature/remove_theia

KateFriedman-NOAA commented 4 years ago

@yangfanglin Any objections if I remove the fv3ics.py script from global-workflow/ush? Users now use UFS_UTILS code/scripts to create ICs.

yangfanglin commented 4 years ago

Kate, I agree the first two steps of the workflow, getting data and run CHGRES can be removed. They have never really worked well . They should be placed outside of the xml for setting up experiments. There are many ways to set up an experiment.

Fanglin

On Wed, Jan 8, 2020 at 10:48 AM Kate Friedman notifications@github.com wrote:

@yangfanglin https://github.com/yangfanglin Any objections if I remove the fv3ics.py script from global-workflow/ush? Users now use UFS_UTILS code/scripts to create ICs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/global-workflow/issues/4?email_source=notifications&email_token=AKY5N2KIUTYADEWC2257IEDQ4XYUDA5CNFSM4J4BE6V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEINAFJI#issuecomment-572129957, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKY5N2KR3UNFZIPVW54F7U3Q4XYUDANCNFSM4J4BE6VQ .

-- Fanglin Yang, Ph.D. Physical Scientist Environmental Modeling Center National Centers for Environmental Prediction 301-6833722; fanglin.yang@noaa.gov http://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/ http://www.emc.ncep.noaa.gov/gmb/STATS_vsdb/

KateFriedman-NOAA commented 4 years ago

Cool...the free-forecast mode getic and fv3ic jobs are still working and use the UFS_UTILS chgres code. I'll need to update it to use the chgres cube code once George makes a new tag with it. I have been helping him test the updated code/scripts on the various platforms. Eventually I'd like to add a first half cycle job to make ICs for cycled mode but that's down my to-do list.

I'll remove the fv3ics.py script, thanks!

KateFriedman-NOAA commented 4 years ago

Sync merged feature/remove_theia with develop branch @ 67dae40

[Kate.Friedman@m71a2 global-workflow]$ git clone https://github.com/NOAA-EMC/global-workflow.git ./feature_remove_theia_merge
Cloning into './feature_remove_theia_merge'...
remote: Enumerating objects: 117, done.
remote: Counting objects: 100% (117/117), done.
remote: Compressing objects: 100% (115/115), done.
remote: Total 29771 (delta 31), reused 21 (delta 2), pack-reused 29654
Receiving objects: 100% (29771/29771), 68.55 MiB | 29.54 MiB/s, done.
Resolving deltas: 100% (20257/20257), done.
[Kate.Friedman@m71a2 global-workflow]$ cd ./feature_remove_theia_merge
[Kate.Friedman@m71a2 feature_remove_theia_merge]$ git checkout feature/remove_theia
Branch feature/remove_theia set up to track remote branch feature/remove_theia from origin.
Switched to a new branch 'feature/remove_theia'
[Kate.Friedman@m71a2 feature_remove_theia_merge]$ git branch
  develop
* feature/remove_theia
[Kate.Friedman@m71a2 feature_remove_theia_merge]$ git merge develop
Merge made by the 'recursive' strategy.
 parm/transfer_gdas_misc.list | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 parm/transfer_gdas_misc.list
[Kate.Friedman@m71a2 feature_remove_theia_merge]$ git status
On branch feature/remove_theia
Your branch is ahead of 'origin/feature/remove_theia' by 2 commits.
  (use "git push" to publish your local commits)

nothing to commit, working tree clean
[Kate.Friedman@m71a2 feature_remove_theia_merge]$ git push origin feature/remove_theia
Counting objects: 3, done.
Delta compression using up to 56 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 372 bytes | 372.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To https://github.com/NOAA-EMC/global-workflow.git
   f78eb1b4..67dae409  feature/remove_theia -> feature/remove_theia
KateFriedman-NOAA commented 4 years ago

Ran quick C192 free-forecast test on Dell. No issues with checkout, build, and run. Will test on Cray and Hera next.

KateFriedman-NOAA commented 4 years ago

Sync merged with develop branch at 1c85197.

KateFriedman-NOAA commented 4 years ago

Pulled bug fix for getic.sh into branch to get it into develop. Committed to feature/remove_theia at bd00cb9.

KateFriedman-NOAA commented 4 years ago

Branch ready for consideration for committal to develop branch. Initiating PR.

KateFriedman-NOAA commented 4 years ago

PR #19 completed. Closing ticket.

KateFriedman-NOAA commented 4 years ago

Deleted feature branch feature/remove_theia:

-bash-4.2$ git push origin --delete feature/remove_theia
To https://github.com/NOAA-EMC/global-workflow.git
 - [deleted]           feature/remove_theia