wgrib2 consitency and consolidation

NOAA-EMC / hpc-stack

Create a software stack for HPC's

GNU Lesser General Public License v2.1

30 stars 36 forks source link

wgrib2 consitency and consolidation #482

Closed aerorahul closed 2 years ago

aerorahul commented 2 years ago

Presently, hpc-stack provides two ways to build and install wgrib2.

NCEPLibs-wgrib2.
Native wgrib2 build from its developer.

This leads to inconsistencies in the artifacts (specifically library) that is used in downstream applications.

This PR:

removes the ability to build NCEPLibs-wgrib2 and rely solely on the build mechanism provided by its developer.
Makes consistent modulefiles for wgrib2 between hierarchies.
Upgrades wgrib2-config.cmake that makes it easy for packages to "find" wgrib2.

aerorahul commented 2 years ago

The build on macOS fails because of name collision in g2 library. I am not sure why this wasn't flagged in the GithubCI of NCEPLIBS-g2, but it did get flagged in the hpc-stack GitHub CI at here.

aerorahul commented 2 years ago

As noted, this PR fails the macOS test because NCEPLIBS-g2 tests has 2 files: test_ixgb2.F90 test_ixgb2.f90 macOS is not a case-sensitive system by default, and thus having two files with the same name causes conflict.

All other tests pass.

aerorahul commented 2 years ago

An issue is opened at https://github.com/NOAA-EMC/NCEPLIBS-g2/issues/288

Hang-Lei-NOAA commented 2 years ago

It has been in a pull requested to be deleted.

On Mon, Aug 15, 2022 at 5:03 PM Rahul Mahajan @.***> wrote:

An issue is opened at NOAA-EMC/NCEPLIBS-g2#288 https://github.com/NOAA-EMC/NCEPLIBS-g2/issues/288

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/hpc-stack/pull/482#issuecomment-1215802413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWSMFHKKDFI5IVYOJEY7TTVZKWDNANCNFSM56SSGKYQ . You are receiving this because your review was requested.Message ID: @.***>

aerorahul commented 2 years ago

It has been in a pull requested to be deleted. … On Mon, Aug 15, 2022 at 5:03 PM Rahul Mahajan @.> wrote: An issue is opened at NOAA-EMC/NCEPLIBS-g2#288 <NOAA-EMC/NCEPLIBS-g2#288> — Reply to this email directly, view it on GitHub <#482 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKWSMFHKKDFI5IVYOJEY7TTVZKWDNANCNFSM56SSGKYQ . You are receiving this because your review was requested.Message ID: @.>

Thanks @Hang-Lei-NOAA I will monitor the PR and when it is merged, resubmit the failed CI jobs.