one line bug fix to RUCLSM

NOAA-EMC / rrfs-workflow

workflow for RRFSv1

Other

12 stars 28 forks source link

one line bug fix to RUCLSM #374

Open hu5970 opened 4 months ago

hu5970 commented 4 months ago

The lowest level of the soil temperature in RUCLSM will be from climate instead of high resolution RRFS. To fix this bug, one line in RUCLSM need to be removed:

FV3/ccpp/physics/physics/SFC_Models/Land/RUC

--- a/physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
+++ b/physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90
@@ -1077,8 +1077,6 @@ CONTAINS
                   tso(i,k,j) = tso1d(k)
         enddo

-        tso(i,nzs,j) = tbot(i,j)
-
         do k=1,nzs
              smfr3d(i,k,j) = smfrkeep(k)
            keepfr3dflag(i,k,j) = keepfr (k)

MatthewPyle-NOAA commented 4 months ago

@hu5970 How critical is this one? What kind of impact does fixing it have? Not inclined to unfreeze the system unless fixing this issue makes things dramatically better.

hu5970 commented 4 months ago

This fixes a bug that set climate T to the lowest level soil. This will gradually impact the top level soil but should not impact the atmosphere too much, or in a short period. There are other bug fixes to the model code from Haiqin on smoke/dust. We can check the PR when it is ready and evaluate the benefit and risk of such bug fixes.