NOAA-EMC / wgrib2

Provides functionality for interacting with, reading, writing, and manipulating GRIB2 files.
12 stars 8 forks source link

Added more tests using FTP #124

Closed AlysonStahl-NOAA closed 1 month ago

AlysonStahl-NOAA commented 2 months ago

Part of #118

edwardhartnett commented 2 months ago

Failing because:

0s Run mkdir ~/data mkdir: cannot create directory ‘/home/runner/data’: File exists Error: Process completed with exit code 1.

I don't understand what this is failing.

I suggest you first remove the data caching and see if it works downloading everything every time. Then we can circle back around to get the cache working...

edwardhartnett commented 2 months ago

If this is adding a large test file (> 2 GB) from FTP then also add an additional CMake option in the main CMake file:

option(FTP_LARGE_TEST_FILES "Fetch and test with very large files on FTP site." OFF)

Then only get the large test file if this additional option is present.

AlysonStahl-NOAA commented 2 months ago

Failing because:

0s Run mkdir ~/data mkdir: cannot create directory ‘/home/runner/data’: File exists Error: Process completed with exit code 1.

I don't understand what this is failing.

I suggest you first remove the data caching and see if it works downloading everything every time. Then we can circle back around to get the cache working...

I fixed this issue in another pull request which has since been merged. It should be working now.

AlysonStahl-NOAA commented 2 months ago

If this is adding a large test file (> 2 GB) from FTP then also add an additional CMake option in the main CMake file:

option(FTP_LARGE_TEST_FILES "Fetch and test with very large files on FTP site." OFF)

Then only get the large test file if this additional option is present.

This option already exists in the main CMake file and is checked for in the CMake file in the tests folder.