search

NOAA-EMC / wgrib2

Provides functionality for interacting with, reading, writing, and manipulating GRIB2 files.
12 stars 8 forks source link

Adding tests which test use of ip external library #129

Open AlysonStahl-NOAA opened 1 month ago

AlysonStahl-NOAA commented 1 month ago

Part of #103

edwardhartnett commented 1 month ago

Is this ready to merge?

AlysonStahl-NOAA commented 1 month ago

Is this ready to merge?

Nope, not yet. I'm working on adding some of Wesley's unmerged changes that make this compatible with the current version of the ip library. The test I have isn't actually working, I was just testing some things on the CI.

edwardhartnett commented 1 week ago

What's the status of this PR?

AlysonStahl-NOAA commented 1 week ago

What's the status of this PR?

From what I understood Wesley was taking over transferring his changes for the newer versions of the ip library. I've been waiting for those changes to complete before I continued with this.

edwardhartnett commented 10 hours ago

It would be great if this PR could be fixed and merged soon. More testing is more good!