Fixing tests so that they are passing consistently

NOAA-EMC / wgrib2

Provides functionality for interacting with, reading, writing, and manipulating GRIB2 files.

12 stars 8 forks source link

Fixing tests so that they are passing consistently #138

Closed AlysonStahl-NOAA closed 1 week ago

AlysonStahl-NOAA commented 4 weeks ago

Part of #137

AlysonStahl-NOAA commented 3 weeks ago

@edwardhartnett @webisu

I keep rerunning the checks to see if I can break them and I'm not encountering the file comparison problem anymore so that seems to be fixed. Before adding the fix, at least one check was failing every other run or so.

I do have one test passing inconsistently, but it seems to be an inconsistent calculation. It's hard to tell what's going on when I can't duplicate the issue anywhere else. Any ideas about how to go about debugging this?

edwardhartnett commented 1 week ago

Resolve your conflicts, comment out your one failing test, and get the rest merged.

Then circle around and solve the broken test as a separate PR.