search

NOAA-EMC / wgrib2

Provides functionality for interacting with, reading, writing, and manipulating GRIB2 files.
12 stars 8 forks source link

use external NCEPLIBS-ip develop branch #143

Closed webisu closed 1 day ago

webisu commented 1 week ago

yet another version of nceplib/ip fix

Part of #115

edwardhartnett commented 1 week ago

Well we only need one version. ;-)

Shall we close the other PR?

edwardhartnett commented 1 week ago

I see that this is failing CI because the CI does not build ip. I will add that to this branch...

webisu commented 1 week ago

They are all the same with different versions of develop.. Close them all.

On Wed, Jun 26, 2024 at 5:27 PM Edward Hartnett @.***> wrote:

Well we only need one version. ;-)

Shall we close the other PR?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/wgrib2/pull/143#issuecomment-2192653854, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIB7ZTRY6Y444WC65KHHO3ZJMW3XAVCNFSM6AAAAABJ4OX3FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGY2TGOBVGQ . You are receiving this because you authored the thread.Message ID: @.***>

edwardhartnett commented 1 week ago

@webisu ok, let's keep this PR open and work on this branch until we get this working...

AlysonStahl-NOAA commented 2 days ago

@edwardhartnett @webisu Looks like things are working now. Did we want to move to using only two options for USE_IPOLATES (ON/OFF) in this pull request?

webisu commented 2 days ago

Yes, The only reason there were two libraries was the need to support rotated lat-lon grids using NCEP and WMO grid templates. A future nceplib/ip will support both templates. Wesley

On Tue, Jul 2, 2024 at 5:23 PM AlysonStahl-NOAA @.***> wrote:

@edwardhartnett https://github.com/edwardhartnett @webisu https://github.com/webisu Looks like things are working now. Did we want to move to using only two options for USE_IPOLATES (ON/OFF) in this pull request?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/wgrib2/pull/143#issuecomment-2203893539, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIB7ZXDPHZCSEFA5HYI5OLZKLOYBAVCNFSM6AAAAABJ4OX3FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTHA4TGNJTHE . You are receiving this because you were mentioned.Message ID: @.***>

edwardhartnett commented 1 day ago

@AlysonStahl-NOAA you will be doing the merges in this repo.

Great job on this @webisu and @AlysonStahl-NOAA . Does this mean we can remove the internal copy of the ip code?

AlysonStahl-NOAA commented 1 day ago

@AlysonStahl-NOAA you will be doing the merges in this repo.

Great job on this @webisu and @AlysonStahl-NOAA . Does this mean we can remove the internal copy of the ip code?

I don't believe the internal copy is referenced anywhere other than the makefile in the lib folder.