search

NOAA-EMC / wgrib2

Provides functionality for interacting with, reading, writing, and manipulating GRIB2 files.
12 stars 8 forks source link

remove lib subdirectory #150

Open edwardhartnett opened 5 days ago

edwardhartnett commented 5 days ago

We should not have a subdirectory named lib, as that is an install subdirectory name, which may lead to confusion.

ALso it only contains a makefile, which we are no longer supporting and should be removed. So seems like the whole lib subdirectory can be removed.

webisu commented 3 days ago

The libs/makefile combines the various libraries to a single library. With the makefile system, the lib/makefile will combine all the .a to a single .a. This makes programs that build with libwgrib2 easier to setup. The python interface requires libwgrib2.so. This library will probably have to include the libraries that wgrib2 calls such as aec, png-1.2, openjpeg. Maybe you can get around it by LD_LIBRARY_PATH but I would never suggest that solution.

The libs/makefile combines the various libraries to a single *.so file. It is not clear how to run with multiple libraries without LDPATH.

On Sat, Jun 29, 2024 at 10:39 AM Edward Hartnett @.***> wrote:

We should not have a subdirectory named lib, as that is an install subdirectory name, which may lead to confusion.

ALso it only contains a makefile, which we are no longer supporting and should be removed. So seems like the whole lib subdirectory can be removed.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/wgrib2/issues/150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIB7ZVPPLQKDFD6VZAVO4LZJ3BJBAVCNFSM6AAAAABKDIBCZGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DCNZYGY3DMMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

webisu commented 3 days ago

I am not saying to keep libs/makefile or libs but something will have to be done to combine libraries that lib/makefile does.

On Sat, Jun 29, 2024 at 10:39 AM Edward Hartnett @.***> wrote:

We should not have a subdirectory named lib, as that is an install subdirectory name, which may lead to confusion.

ALso it only contains a makefile, which we are no longer supporting and should be removed. So seems like the whole lib subdirectory can be removed.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/wgrib2/issues/150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIB7ZVPPLQKDFD6VZAVO4LZJ3BJBAVCNFSM6AAAAABKDIBCZGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DCNZYGY3DMMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

edwardhartnett commented 3 days ago

OK, we'll take a look at that...