search

NOAA-EMC / wgrib2

Provides functionality for interacting with, reading, writing, and manipulating GRIB2 files.
27 stars 13 forks source link

require NCEPLIBS-ip-5.1.0 in the cmake build (after it is released) #189

Closed edwardhartnett closed 2 months ago

edwardhartnett commented 2 months ago

Soon @AlexanderRichert-NOAA will release NCEPLIBS-ip-5.1.0 which will have the rotated lat/lon interpolation.

Once that happens, does wgrib2 always require NCEPLIBS-ip-5.1.0 or better? Or can we still work with older versions of ip/sp?

In cmake we have:

# If user wants to use NCEPLIBS-ip, find it and the sp library.
message(STATUS "Checking if the user want to use NCEPLIBS-ip...")
if(USE_IPOLATES)
  find_package(ip CONFIG REQUIRED)
  list(APPEND definitions_list -DIPOLATES_LIB="ipolates_lib_4")
  list(APPEND definitions_list -DUSE_IPOLATES)
endif()

We need to decide about the version, whether sp is ever required, and check that in the cmake.

I think this assumes ip 5.0.0.

In fact, for

webisu commented 2 months ago

You really need ip v5.1.0+ once v5.1.0 is released. Some centers are making the rotated lat-lon grid the primary grid for the regional models. The advantage is that you can avoid a double interpolation error.

On Wed, Jul 17, 2024 at 10:26 AM Edward Hartnett @.***> wrote:

Soon @AlexanderRichert-NOAA https://github.com/AlexanderRichert-NOAA will release NCEPLIBS-ip-5.1.0 which will have the rotated lat/lon interpolation.

Once that happens, does wgrib2 always require NCEPLIBS-ip-5.1.0 or better? Or can we still work with older versions of ip/sp?

In cmake we have:

If user wants to use NCEPLIBS-ip, find it and the sp library.

message(STATUS "Checking if the user want to use NCEPLIBS-ip...") if(USE_IPOLATES) find_package(ip CONFIG REQUIRED) list(APPEND definitions_list -DIPOLATES_LIB="ipolates_lib_4") list(APPEND definitions_list -DUSE_IPOLATES) endif()

We need to decide about the version, whether sp is ever required, and check that in the cmake.

I think this assumes ip 5.0.0.

In fact, for

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/wgrib2/issues/189, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIB7ZRDGZRL4UCEXIY4NOTZMZ5JXAVCNFSM6AAAAABLAYH5IKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTGNZWGY2DMMA . You are receiving this because you were assigned.Message ID: @.***>

edwardhartnett commented 2 months ago

OK, so we need to ensure that the CMake build enforces that by requiring ip-5.1.0 (when it comes out).

We will still be able to build without ip, correct?

webisu commented 2 months ago

Can build without ip as long as it is turned off in CMakeLists.txt.

On Wed, Jul 17, 2024 at 10:57 AM Edward Hartnett @.***> wrote:

OK, so we need to ensure that the CMake build enforces that by requiring ip-5.1.0 (when it comes out).

We will still be able to build without ip, correct?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/wgrib2/issues/189#issuecomment-2233530493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIB7ZS4CPAB7F2A4GVEOMTZM2A4FAVCNFSM6AAAAABLAYH5IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGUZTANBZGM . You are receiving this because you were assigned.Message ID: @.***>

AlexanderRichert-NOAA commented 2 months ago

It is released: https://github.com/NOAA-EMC/NCEPLIBS-ip/releases/tag/v5.1.0