NOAA-EMC / wgrib2

Provides functionality for interacting with, reading, writing, and manipulating GRIB2 files.
27 stars 13 forks source link

remove netCDF tarball from the repo and the makefile build #69

Closed edwardhartnett closed 4 months ago

edwardhartnett commented 9 months ago

Currently there is a very old netcdf-c tarball in the repo and the makefile build:

netcdf-3.6.3.tar.gz

This code is over 20 years old! It should never be distributed - bug fixes have taken place, even in the classic code, which need to be used.

Instead, just rely on a local netcdf-c build. If you need to, you can find out whether netCDF-4 has been enabled in the netCDF library. So it's possible to build and install the most recent netCDF release, build without netCDF-4, and get the classic library. So you can still support a classic only netCDF-3 library. And the current release is also fully backward compatible, even when build with netCDF-4.

So the netCDF tarball should be removed. makefile build should be changed to accept the location of the netCDF libraries (perhaps as an environment var?) and look for them there. The CMake build will look for netCDF and find it.

The netCDF tarball will not be installed any further and can be removed.