search

NOAA-EMC / wgrib2

Provides functionality for interacting with, reading, writing, and manipulating GRIB2 files.
27 stars 13 forks source link

Remove proj-4.8.0.tar.gz from the repo #82

Closed edwardhartnett closed 4 months ago

edwardhartnett commented 9 months ago

We need to remove proj-4.8.0.tar.gz from the build.

I note that the readme says:

Proj4 is a open-source geolocation library.  Usually the faster gctpc library
is used for geolocation.  At the current time, Proj4 does not add any
capabilty over gctpc.

So it sounds like proj4 should just be dropped. Does that make sense?

webisu commented 9 months ago

Ed, That comment is old. Proj4 should be replaced by the current version of Proj (and tested). Wesley

On Wed, Jan 3, 2024 at 8:55 AM Edward Hartnett @.***> wrote:

We need to remove proj-4.8.0.tar.gz from the build.

I note that the readme says:

Proj4 is a open-source geolocation library. Usually the faster gctpc library is used for geolocation. At the current time, Proj4 does not add any capabilty over gctpc.

So it sounds like proj4 should just be dropped. Does that make sense?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/wgrib2/issues/82, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIB7ZQCFOT4PGEBYYUSB2DYMVPOXAVCNFSM6AAAAABBLO5SDKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DIMBXHEYDONI . You are receiving this because you were assigned.Message ID: @.***>

edwardhartnett commented 9 months ago

OK, proj is an external project, correct?

edwardhartnett commented 4 months ago

@AlysonStahl-NOAA have you removed all tarballs from the repo?

AlysonStahl-NOAA commented 4 months ago

Yep, that's taken care of.