NOAA-EMC / wxflow

Tools for Weather Workflows
https://wxflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
0 stars 7 forks source link

Add support for HPSS #22

Closed DavidHuber-NOAA closed 5 months ago

DavidHuber-NOAA commented 5 months ago

Description Adds classes to interface with the hsi and htar commands with several helper methods for easier use. Resolves #2.

Type of change

How Has This Been Tested?

Checklist

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 23.21429% with 129 lines in your changes are missing coverage. Please review.

Project coverage is 47.99%. Comparing base (81bfec0) to head (7d7c83d).

Files Patch % Lines
src/wxflow/hsi.py 16.82% 89 Missing :warning:
src/wxflow/htar.py 30.43% 32 Missing :warning:
src/wxflow/fsutils.py 33.33% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #22 +/- ## =========================================== - Coverage 50.88% 47.99% -2.90% =========================================== Files 16 18 +2 Lines 1476 1642 +166 Branches 313 330 +17 =========================================== + Hits 751 788 +37 - Misses 669 798 +129 Partials 56 56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DavidHuber-NOAA commented 5 months ago

I just found a bug in Htar that I am fixing now. I will let you know when it's ready to go again. Should be soon.

DavidHuber-NOAA commented 5 months ago

@aerorahul Alright, it's good to go. My tests were only testing the case of sending one file to an HPSS tar archive. Expanding that to test multiple files found that each file being sent to an archive needs its own argument. The test has been updated to check for this and it passes on Hera.