NOAA-EMC / wxflow

Tools for Weather Workflows
https://wxflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
0 stars 7 forks source link

Create task_config member variable upon initialization #30

Closed DavidNew-NOAA closed 3 months ago

DavidNew-NOAA commented 3 months ago

Description

This PR creates the task_config member variable in the Task __init__ function. Normally it is created upon initialization of a child subclasses of Task, but since it is expected to exist for every application of the Task class I've seen so far, it's better to create it at initialization.

This PR also eliminates runtime_config, since it's mostly redundant and renames the config member variable with a leading underscores to emphasize that they should be treated as private.

This PR is a companion to Global Workflow PR #2654 which replaces any reference to config or runtime_config member variables with task_config.

Type of change

How Has This Been Tested?

Checklist

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 48.17%. Comparing base (8406bee) to head (c710e9f). Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/wxflow/task.py 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #30 +/- ## =========================================== + Coverage 47.93% 48.17% +0.23% =========================================== Files 18 18 Lines 1650 1642 -8 Branches 335 334 -1 =========================================== Hits 791 791 + Misses 799 791 -8 Partials 60 60 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.