AWS needs these changes

[weihuang-jedi]

Description

workflow/setup_xml.py failed on AWS, to get work, we need to modify wxflow/configuration.py.

Type of change

This fixes issue: https://github.com/NOAA-EMC/wxflow/issues/31

• [ x] Bug fix (non-breaking change which fixes an issue)
• [x ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

This code has tested on AWS.

• [ ] pynorms
• [ ] pytests

Checklist

• [ x] My code follows the style guidelines of this project
• [x ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] My changes need updates to the documentation. I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] New and existing tests pass with my changes
• [ ] Any dependent changes have been merged and published

[aerorahul]

Can you describe the failure exactly?

[weihuang-jedi]

With current code, it returns error:

setup_xml.py failed with messages like:

Traceback (most recent call last): File "/contrib/Wei.Huang/src/global-workflow-cloud/workflow/setup_xml.py", line 79, in main() File "/contrib/Wei.Huang/src/global-workflow-cloud/workflow/setup_xml.py", line 73, in main xml = rocoto_xmlfactory.create(f'{net}{mode}', app_config, rocoto_param_dict) File "/contrib/Wei.Huang/src/global-workflow-cloud/workflow/wxflow/factory.py", line 71, in create return self._builders[key](*args, kwargs) File "/contrib/Wei.Huang/src/global-workflow-cloud/workflow/rocoto/gfs_forecast_only_xml.py", line 12, in init super().init(app_config, rocoto_config) File "/contrib/Wei.Huang/src/global-workflow-cloud/workflow/rocoto/workflow_xml.py", line 28, in init task_list = get_wf_tasks(app_config) File "/contrib/Wei.Huang/src/global-workflow-cloud/workflow/rocoto/workflow_tasks.py", line 21, in get_wf_tasks tasks.append(task_obj.get_task(task_name)) File "/contrib/Wei.Huang/src/global-workflow-cloud/workflow/rocoto/tasks.py", line 244, in get_task return getattr(self, task_name, *args, *kwargs)() File "/contrib/Wei.Huang/src/global-workflow-cloud/workflow/rocoto/gfs_tasks.py", line 29, in stage_ic prefix = @. @.@@./atmos" File "/contrib/Wei.Huang/src/global-workflow-cloud/workflow/wxflow/attrdict.py", line 84, in missing raise KeyError(name) KeyError: 'BASE_CPLIC'

Before we change tasks.py, and others, the failure are different.

On Wed, Jun 12, 2024 at 2:45 PM Rahul Mahajan @.***> wrote:

Can you describe the failure exactly?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/wxflow/pull/32#issuecomment-2163868537, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMCH67CB2YF46JBEQS554TZHCXNRAVCNFSM6AAAAABJGZH5T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTHA3DQNJTG4 . You are receiving this because you authored the thread.Message ID: @.***>

[aerorahul]

The issue appears to be in the config file of the experiment and not in this code. Please check if the missing key is defined. wxflow is agnostic to HPC or cloud.

[weihuang-jedi]

OK, I'll try more at the config side.

On Wed, Jun 12, 2024 at 5:03 PM Rahul Mahajan @.***> wrote:

The issue appears to be in the config file of the experiment and not in this code. Please check if the missing key is defined. wxflow is agnostic to HPC or cloud.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/wxflow/pull/32#issuecomment-2164034851, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMCH633IJZ35XXIIHAST73ZHDHURAVCNFSM6AAAAABJGZH5T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRUGAZTIOBVGE . You are receiving this because you authored the thread.Message ID: @.***>

[weihuang-jedi]

@aerorahul As you suggested, after check the code, we figured that we can avoid the changes in wxflow. I am closing this PR now. Thanks, Wei