NOAA-EMC / wxflow

Tools for Weather Workflows
https://wxflow.readthedocs.io/en/latest
GNU Lesser General Public License v3.0
0 stars 7 forks source link

Parse comma-separated list as python list #39

Closed WalterKolczynski-NOAA closed 1 month ago

WalterKolczynski-NOAA commented 1 month ago

Description Adds parsing of a comma-separated list to a python list to Configuration.

In support of NOAA-EMC/global-workflow#2274

Type of change

How Has This Been Tested?

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.12%. Comparing base (86bfe2b) to head (c68d7dc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #39 +/- ## =========================================== + Coverage 50.06% 50.12% +0.06% =========================================== Files 18 18 Lines 1650 1652 +2 Branches 337 339 +2 =========================================== + Hits 826 828 +2 Misses 765 765 Partials 59 59 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WalterKolczynski-NOAA commented 1 month ago

looks good.

I am wondering if this will have an unintended side-effect on g-w where such a string exists in one of the configs. It should be rectified in the g-w if it does.

I thought about that, because some of the namelist variables do use comma-separated lists the same way. But we don't really use any of those in the python system (and if we were to use them in python somewhere down the line, we would probably want them in list for too).