search

NOAA-FIMS / FIMS

The repository for development of FIMS
https://noaa-fims.github.io/FIMS/
GNU General Public License v3.0
11 stars 7 forks source link

[Feature]: Make units explicit and convert between units #562

Open ChristineStawitz-NOAA opened 1 month ago

ChristineStawitz-NOAA commented 1 month ago

Is your feature request related to a problem? Please describe.

Implicit unit specification causes a lot of mistakes and wasted time in stock assessment models

Describe the solution you would like.

Users should be able to specify units in any standard format and the model code converts appropriately.

Describe alternatives you have considered

We could also enforce one set of units and make the user do the conversion themselves

Statistical validity, if applicable

No response

Describe if this is needed for a management application

No response

Additional context

No response

kellijohnson-NOAA commented 1 month ago

If we allow users to input quantities in multiple units would the output be in the original units or in standard units?

ChristineStawitz-NOAA commented 2 weeks ago

@Bai-Li-NOAA and I discussed this - we'd need to either:

  1. convert internally within C++ so all output units are standard
  2. do some passing of information from the input interface to the output of what the units are
  3. rename quantities within the C++ model to specify units e.g. catch_mt vs catch_kg such that ADREPORT includes some definition of units, as the object name is the only thing in ADREPORT