Closed k-doering-NOAA closed 3 weeks ago
Hello reviewer, thanks for taking the time to review this PR!
nit:
(for nitpicking) before making the suggestion. For example, nit:
I prefer using a data.frame()
instead of a matrix
because...This PR is now ready to be merged, no changes needed
.@Andrea-Havron-NOAA I included you as a reviewer since you discovered this issue!
@Andrea-Havron-NOAA would you be able to review this? Or should someone else be assigned?
@Andrea-Havron-NOAA would you be able to review this? Or should someone else be assigned?
I can review this!
What is the feature?
rserver
in the command line.more details: https://github.com/rocker-org/devcontainer-features/blob/main/src/rstudio-server/README.mdHow have you implemented the solution?
I think the inclusion of the cli and r lang packages was causing conflicts, which resulted in the codespace failing to build. I removed all packages that weren't dependencies of FIMS (and added some that are, but weren't listed) and was able to successfully build a codespace.
Does the PR impact any other area of the project?
No
How to test this change
Try building a codespace on this branch and see if it succeeds.
Developer pre-PR checklist