NOAA-FIMS / FIMS

The repository for development of FIMS
https://noaa-fims.github.io/FIMS/
GNU General Public License v3.0
11 stars 7 forks source link

removing mkObj from codebase #587

Closed MOshima-PIFSC closed 3 weeks ago

MOshima-PIFSC commented 3 weeks ago

What is the feature?

How have you implemented the solution?

I removed the the script with the function (io.R) and ran devtools::document() to remove man/mkObj.Rd, and removed the function from the namespace.

Does the PR impact any other area of the project?

None

How to test this change

I ran devtools::check() and the changes did not cause any errors.

Developer pre-PR checklist

github-actions[bot] commented 3 weeks ago

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

Checklist

MOshima-PIFSC commented 3 weeks ago

@Andrea-Havron-NOAA I made the changes you requested and now it is passing all tests!

Andrea-Havron-NOAA commented 3 weeks ago

looks good!