Closed MOshima-PIFSC closed 3 weeks ago
Hello reviewer, thanks for taking the time to review this PR!
nit:
(for nitpicking) before making the suggestion. For example, nit:
I prefer using a data.frame()
instead of a matrix
because...This PR is now ready to be merged, no changes needed
.@Andrea-Havron-NOAA I made the changes you requested and now it is passing all tests!
looks good!
What is the feature?
mkObj()
from codebase because the function was no longer usedHow have you implemented the solution?
I removed the the script with the function (
io.R
) and randevtools::document()
to remove man/mkObj.Rd, and removed the function from the namespace.Does the PR impact any other area of the project?
None
How to test this change
I ran
devtools::check()
and the changes did not cause any errors.Developer pre-PR checklist