search

NOAA-FIMS / collaborative_workflow

contributors guide to FIMS, managing collaborations
https://noaa-fims.github.io/collaborative_workflow/
4 stars 1 forks source link

Add code review flowchart #138

Closed Bai-Li-NOAA closed 2 weeks ago

Bai-Li-NOAA commented 1 month ago

This PR adds the code review flowchart to section 7.14.

Bai-Li-NOAA commented 2 weeks ago

@k-doering-NOAA, please let me know if you have some time to review the pull request.

k-doering-NOAA commented 2 weeks ago

I won't have time until next week, so feel free to reassign if needed earlier than that!

On Tuesday, June 11, 2024, Bai Li - NOAA @.***> wrote:

@k-doering-NOAA https://github.com/k-doering-NOAA, please let me know if you have some time to review the pull request.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-FIMS/collaborative_workflow/pull/138#issuecomment-2161422435, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALVJ4H7NBBFVGVNJBDXSFYLZG5CPNAVCNFSM6AAAAABIRO75IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGQZDENBTGU . You are receiving this because you were mentioned.Message ID: @.***>

--

Kathryn Doering (Pronouns: she/her) NOAA Fisheries Integrated Toolbox (FIT) https://www.fisheries.noaa.gov/resource/tool-app/noaa-fisheries-integrated-toolbox Coordinator

NOAA Fisheries Office of Science and Technology | U.S. Department of Commerce

Schedule a meeting with me! https://calendly.com/kathryn-doering

Office/Mobile: ‪‪(240) 621-1647‬‬‪

www.fisheries.noaa.gov

My working hours are typically M-F 8 am -4:30 pm Pacific Time.

kellijohnson-NOAA commented 2 weeks ago

The text in ### Assigning Reviewers does not match the diagram and should be modified to something like the proposed text below

### Assigning Reviewers

Reviewers of PRs for changes to the codebase in FIMS should be
suggested by the author of the PR. For those FIMS Implementation
Team Members that keep their status in Github current (see ["Setting
a status"](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-profile/customizing-your-profile/personalizing-your-profile#setting-a-status)
for more information), authors can use the status information to
prevent assigning a reviewer who is known to be "Busy".

If a review has been assigned to you and you don't feel like you have
the expertise to address it properly, please respond directly to the
PR so a different reviewer can be found promptly.
Bai-Li-NOAA commented 2 weeks ago

@kellijohnson-NOAA Thanks for the review. Let me know if you have any suggestions!

kellijohnson-NOAA commented 2 weeks ago

No additional changes needed, it looks good.