search

NOAA-GFDL / CatalogBuilder

Toolset to build, validate, modify, and use intake-esm based data catalogs
3 stars 3 forks source link

schema edits for MDTF interoperability #10

Closed aradhakrishnanGFDL closed 3 months ago

aradhakrishnanGFDL commented 3 months ago

Following this https://github.com/NOAA-GFDL/MDTF-diagnostics/issues/588, this issue tracks the following changes to the schema

Change: modeling_realm to realm (GFDL Catalog Builder) Change: temporal_subset to time_range (GFDL Catalog Builder) Add: standard_name (GFDL Catalog Builder)

ceblanton commented 3 months ago

This is already fixed, isn't it?

https://github.com/NOAA-GFDL/CatalogBuilder/blob/main/catalogbuilder/cats/gfdl_template.json

aradhakrishnanGFDL commented 3 months ago

This is already fixed, isn't it?

https://github.com/NOAA-GFDL/CatalogBuilder/blob/main/catalogbuilder/cats/gfdl_template.json

Yes, but just the json seemed to updated. We need sample config yaml files and the test configs in CI also to be updated which is now done.

aradhakrishnanGFDL commented 3 months ago

standard_name addition is pending. @Ciheim this PR will add an empty column that you will fill in your feature addition, or want your PR to take care of that as well?