#1 - Create full_coupler_mod

NOAA-GFDL / FMScoupler

Other

13 stars 55 forks source link

#1 - Create full_coupler_mod #104

Closed mlee03 closed 5 months ago

mlee03 commented 8 months ago

In this PR, module use statements and subroutine definitions found in coupler_main.F90 have been moved to a newly created full_coupler_mod module. In this version of full_coupler_mod most of the imported procedures have been marked as public but as coupler subroutines are defined, many of these procedures will become private.

Experiments in AM4, AM5, CM4, SPEAR, OM4_extra, and OMIP_CORE2 xmls for regression testing pass.

thomas-robinson commented 8 months ago

@mlee03 why not jus merge into main? Why are you using a coupler_dev branch?

mlee03 commented 8 months ago

@thomas-robinson I don't want to be the person who broke main :grin:

thomas-robinson commented 8 months ago

main is the development branch. That's where this PR should go. We don't need a different branch for everyone's development.

mlee03 commented 6 months ago

@thomas-robinson @bensonr, any additional changes?

mlee03 commented 6 months ago

@thomas-robinson , BEHOLD, everything passes! READY FOR REVIEW