search

NOAA-GFDL / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code
Other
56 stars 118 forks source link

Ubar not initialized for some SW dynamics test cases #255

Closed bensonr closed 1 year ago

bensonr commented 1 year ago

Describe the bug For at least test_case = 0, 6, 7, 9, there are no initial values given for Ubar. When running in debug mode, there is a crash in _initwinds due to undefined Ubar.

To Reproduce Run CI tests for BTwave, BLvortex, or RHwave after compiling solo SW executable.

Expected behavior Expect Ubar to be defined within each select case option in _initcase

System Environment Describe the system environment, include: all compilers that do not initialize all variables to zero by default

Additional context N/A

lharris4 commented 1 year ago

Hi, Rusty. For all of these cases Ubar should be 0. The variable Ubar is used as a temporary or for input to init_winds(), and is set on a case-by-case basis. (This file and especially init_case() have become a mess over the years and needs some restructuring to move case definitions into individual subroutines, to avoid some of this confusion.)

bensonr commented 1 year ago

Thanks @lharris4 I'll get the necessary definition(s) added and put in a PR shortly.