dev/gfdl branch remove deprecated io

NOAA-GFDL / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code

Other

57 stars 118 forks source link

dev/gfdl branch remove deprecated io #260

Closed laurenchilutti closed 1 year ago

laurenchilutti commented 1 year ago

Description

Removing the final remaining deprecated fmsio calls within the dev/gfdl branch.

Fixes #256

How Has This Been Tested?

Still needs to be fully tested - requires that all components of the GFDL models be updated.

Checklist:

Please check all whether they apply or not

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

laurenchilutti commented 1 year ago

@uramirez8707 and I were discussing how and when to merge in these changes. My concern is that this PR removes some calls to old fmsio that are needed while other components still use old io (e.g. set_domain, nullify_domain, set_filename_appendix). Uriel has suggested using #ifdef statements surounding the calls that need to stay until old fmsio is fully deprecated. Another option is to keep this update on a separate branch while testing (could be dev/gfdl_test) once we fully test that branch with the GFDL models, FMS 2023.02-alpha1, and all other updated components, we can then merge it into the dev/gfdl branch.

@bensonr @uramirez8707 what would you recommend I do?

bensonr commented 1 year ago

Besides atmospheric physics, what other things rely on FV3 for these calls?

laurenchilutti commented 1 year ago

I don't think there is anything else that relies on FV3 for those calls.

laurenchilutti commented 1 year ago

It should be safe to merge this as users should be using tags for the dev/gfdl branch. @uramirez8707 @bensonr This PR is just a cherry-pick of the commits in my other PR which you have both reviewed. Could you please review this as well and I will merge this?

laurenchilutti commented 1 year ago

I have just pushed a commit that should resolve @bensonr comments. If this is acceptable I will merge this PR into the dev/gfdl branch and cherry-pick this last commit to the main branch, as the deprecated io PR to main has already been merged.