Add capability to read IAU increments in cubed sphere format

[mark-a-potts]

This PR adds the capability to read in NetCDF-based cubed-sphere increments generated by JEDI. It includes a new (optional) namelist option to specify that non-gaussian formatted increment files are to be read.

Fixes # (issue)

How Has This Been Tested?

Two unit tests have been added to the code and can be run via ctest after the build.

Checklist:

Please check all whether they apply or not

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] Any dependent changes have been merged and published in downstream modules

[mark-a-potts]

Thank you for designing this very useful functionality for the IAU on the native cubed-sphere grid, which promises to make a lot of the DA process smoother and can leverages some of JEDI's new features. There are some concerns I have about the coding that could be improved by leveraging existing functionality in FMS or by following similar codes already within FV3.

Thanks for take a look so quickly. I have been working with Cory Martin at EMC to test this out as part of a JEDI-based workflow, and it is still definitely in draft format. That said, this is exactly the kind of feedback we wanted to get before going too far down the rabbbit hole. I'll take a look at each of your suggestions and make the appropriate changes.

[lharris4]

Hi, Mark. Glad to help.

Lucas

On Wed, Jun 7, 2023 at 3:14 PM Mark Potts @.***> wrote:

Thank you for designing this very useful functionality for the IAU on the native cubed-sphere grid, which promises to make a lot of the DA process smoother and can leverages some of JEDI's new features. There are some concerns I have about the coding that could be improved by leveraging existing functionality in FMS or by following similar codes already within FV3.

Thanks for take a look so quickly. I have been working with Cory Martin at EMC to test this out as part of a JEDI-based workflow, and it is still definitely in draft format. That said, this is exactly the kind of feedback we wanted to get before going too far down the rabbbit hole. I'll take a look at each of your suggestions and make the appropriate changes.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/274#issuecomment-1581371032, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUQRVCTUGLZV7I65WWDVCLXKDHHRANCNFSM6AAAAAAY6AGHE4 . You are receiving this because you commented.Message ID: @.***>

[lharris4]

Hi, @mark-a-potts . Is this still a WIP or is it ready for review?

[mark-a-potts]

It is still in progress. I updated it recently so that EMC can do some testing with a current version of the UFS-WM. Thanks for checking!

[lharris4]

Hi, Mark. Thank you for your update. Please let us know if you have any questions or need help.

Lucas

On Mon, Aug 7, 2023 at 3:27 PM Mark Potts @.***> wrote:

It is still in progress. I updated it recently so that EMC can do some testing with a current version of the UFS-WM. Thanks for checking!

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/274#issuecomment-1668456963, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUQRVBLLKOCAHTZ5THYL3LXUE6RPANCNFSM6AAAAAAY6AGHE4 . You are receiving this because you commented.Message ID: @.***>

[bensonr]

@mark-a-potts - is this PR still being actively developed?

[mark-a-potts]

I think EMC is about ready to start using this capability actively, so I just updated this again and have tested it with some accompanying changes to the fv3atm repo.

[DavidNew-NOAA]

Hi @laurenchilutti I'm working on an updated version of this PR that adds the ability to read cubed sphere increments both inside and outside the IAU framework. I'm hoping to submit a PR today or Monday once testing is complete.

[laurenchilutti]

@DavidNew-NOAA Thank you for the update! When that new PR comes in would you like me to close this one?

[DavidNew-NOAA]

@laurenchilutti Yes, that's you could probably close it.

[DavidNew-NOAA]

@laurenchilutti #342 and FV3 PR #837 are ready for review. cc @XiaqiongZhou-NOAA @bensonr @lharris4 @mark-a-potts

[laurenchilutti]

Closing, as PR #342 replaces this PR.