NOAA-GFDL / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code
Other
56 stars 118 forks source link

Write netcdf axis variables using the same real kind as data variables #283

Closed DusanJovic-NOAA closed 11 months ago

DusanJovic-NOAA commented 1 year ago

Description

Currently, the axis data type in restart files is always "double" regardless of the data type (float vs. double) of used for data variables. This PR updates io routines so that axis data type corresponds to the actual precision used for data variables. This change is necessary to make restart files bit-identical to the restart files written out by the write grid component in UFS weather model.

Fixes # (issue) https://github.com/NOAA-EMC/fv3atm/issues/696

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration (e.g. compiler, OS). Include enough information so someone can reproduce your tests.

Full regression test of the ufs weather model passed on Hera (both Intel and GNU compilers) and Orion.

Checklist:

Please check all whether they apply or not

jkbk2004 commented 11 months ago

@laurenchilutti All tests are done at https://github.com/ufs-community/ufs-weather-model/pull/1903. Please, go ahead to merge this pr.