Include surface ocean current in the computation of air-sea fluxes

NOAA-GFDL / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code

Other

56 stars 118 forks source link

Include surface ocean current in the computation of air-sea fluxes #311

Closed binli2337 closed 7 months ago

binli2337 commented 8 months ago

Description

Update surface layer scheme to include surface ocean current in the computation of air sea fluxes. Transfer surface ocean current field to nested grids.

Fixes #312

How Has This Been Tested?

The updated code has been tested successfully in the HAFS-MOM6 application.

Checklist:

Please check all whether they apply or not

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

Co-authored-by @binli2337 ,@BinLiu-NOAA, @weiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA

lharris4 commented 8 months ago

Hi, @binli2337 . I take it this is to be able to transmit the surface currents between the parent and nested grids, something that the physics itself does not support? Is this capability needed for other variables as well?

Thanks, Lucas

binli2337 commented 8 months ago

@lharris4 Sea surface temperature (tsfco) also needs to be transferred from parent grid to nested grid. SST was already been transferred from parent to nested gird before this PR.

BinLiu-NOAA commented 8 months ago

Hi, @binli2337 . I take it this is to be able to transmit the surface currents between the parent and nested grids, something that the physics itself does not support? Is this capability needed for other variables as well?

Thanks, Lucas

@lharris4, you are right. The transit of coupling variables (SST, Sea Surface Current) between the parent and nested grids currently relies on the FV3dycore and FMS capabilities. It cannot be done in the physics side currently. As @binli2337 mentioned, this has been previously implemented for SST and sea surface roughness variables. And in this PR, we are trying to add the SSC u/v components.

Meanwhile, you might recall the ongoing PR #272 from @dkokron, which should help to speed up the parent to nest transition process.

Thanks!

BinLiu-NOAA commented 7 months ago

I think this is OK given that it extends a previously defined capability used for operations. However I really think this is something the flux coupler needs to handle, by transmitting surface ocean conditions (SST, SSH, Us, Vs, roughness length, etc.) to the appropriate domain, nested or not.

I would appreciate if you would open an issue within the coupling library.

Thanks, Lucas

Thanks, @lharris4! And agreed. We already have an issue created under ufs-weather-model (ufs-community/ufs-weather-model/issues/1884) regarding establish/optimize the capability of coupling both FV3ATM parent domain and static/moving nest domain with other earth modeling components. Thanks!

lharris4 commented 7 months ago

Hi, Bin. Thanks for opening this issue.

Lucas

On Tue, Jan 23, 2024 at 12:01 PM Bin Liu @.***> wrote:

@.**** approved this pull request.

Changes look good to me.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/311#pullrequestreview-1839374482, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUQRVGTA2JTCZKZKICUM2LYP7UGBAVCNFSM6AAAAABBZNQF7SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZZGM3TINBYGI . You are receiving this because you were mentioned.Message ID: @.***>

zach1221 commented 7 months ago

Testing is complete on ufs-wm 2104. @bensonr would you be able to merge this PR for us please?