NOAA-GFDL / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code
Other
56 stars 118 forks source link

Revert #302 #317

Closed spencerkclark closed 7 months ago

spencerkclark commented 7 months ago

Description

Per offline discussion with @lharris4, the fix made in #302 may not be scientifically correct. This PR reverts that change for now, though reopens #301.

How Has This Been Tested?

There is not really an easy way to test this other than that the code compiles, which should be covered by CI.

Checklist:

Please check all whether they apply or not

bensonr commented 7 months ago

@lharris4 - if you are okay with this, I'll merge it as soon as the checks finish.

spencerkclark commented 7 months ago

@bensonr, while I have you, could you go ahead and merge #316? Thanks!

bensonr commented 7 months ago

@spencerkclark - if you'd like me to revert #302, I can simply press a button and it will take that change out. I don't think we need a this PR.